Re: Broken CI

2021-12-24 Thread Volkan Yazıcı
I have simplified(?) the GitHub Actions `build` workflow in `release-2.x`. Removed `action-surefire-report` usage, hence no extra privileges should be necessary anymore. Removed the `-Dmaven.test.failure.ignore=true` flag, hence all tests need to pass. On Tue, Dec 21, 2021 at 3:10 AM Gary Gregory

Re: Broken CI

2021-12-24 Thread Volkan Yazıcı
`Error: Resource not accessible by integration` failure caused by `action-surefire-report` trying to access the job triggered by a user who doesn't have commit rights to the repo. I have actually tried to explain this in detail in my earlier email. Let me know if that wasn't clear enough. On Thu,

Re: Broken CI

2021-12-23 Thread Gary Gregory
I rarely have issues running tests from the mvn command line. Whatever we have set up in GitHub seems quite complicated compared to most projects I've seen. From Eclipse, sometimes tests fail, but I never researched it, the mvm cmd line is what matters most anyway. G Gary On Thu, Dec 23, 2021, 1

Re: Broken CI

2021-12-23 Thread Tim Perry
My issues were all on master. I've always been able to work on release-2.x in IntelliJ or Eclipse without any issue. I'll have to check out master and see if it works now. I have it on the back burner to try to figure out an improved status logger life cycle. On Thu, Dec 23, 2021 at 9:34 AM Carte

Re: Broken CI

2021-12-23 Thread Carter Kozak
I haven't had a test flake locally in the last 6 months (at least), if we see flaky tests I'm in favor of fixing them rather than working around them. fwiw the non GitHub-actions tests work great on the release-2.x branch in my experience, when they aren't overwhelmed accessing build nodes anyho

Re: Broken CI

2021-12-23 Thread Gary Gregory
I'm not talking about failing tests but about some other build silliness that does not feel necessary, for example: https://github.com/apache/logging-log4j2/runs/4620228443?check_suite_focus=true Shows: Run scacap/action-surefire-report@v1 Going to parse results form **/*-reports/TEST-*.xml Resu

Re: Broken CI

2021-12-23 Thread Tim Perry
Is it worth marching those tests with @Ignore and filing a Jira for each one? That does seem to set a bad precedent though. Last time I tried I couldn't get the mainline code to load in IntelliJ or Eclipse because of the packing changes that were in progress. Did that get fixed? If so, I might be

Re: Broken CI

2021-12-23 Thread Volkan Yazıcı
Since, there are some tests which occasionally constantly fail, we use `-Dmaven.test.failure.ignore=true` in `verify` goal. This causes a build with test failures to be marked green. The 3rd party component, `scacap/action-surefire-report@v1`, is used to feed these failures back into GitHub Actions

Broken CI

2021-12-20 Thread Gary Gregory
After getting https://github.com/apache/logging-log4j2/pull/646 in what I think is a good state, I have no idea if it is safe or not to merge because the 1st build GitHub shows is red: https://github.com/apache/logging-log4j2/runs/4589771553?check_suite_focus=true I don't use GH actions the way we