Re: [logging-pipelines] branch master updated: Use Java 11 for master branch

2021-05-08 Thread Matt Sicker
I've updated the function to use a tool installation to get the path instead of hard-coding it. I've also updated it to check if it's running in log4j (master) or chainsaw (any branch) to choose a different default jdk. Unfortunately, Jenkins went down for maintenance around the same time I pushed

Re: [logging-pipelines] branch master updated: Use Java 11 for master branch

2021-04-06 Thread Matt Sicker
Oh right, that could be done various ways. I'll figure something out. Maybe the tool DSL works properly now (I think it was buggy when using parallel builds). On Tue, 6 Apr 2021 at 08:53, Apache wrote: > > Can we not require a Jenkinsfile in each project that sets properties to > control the beh

Re: [logging-pipelines] branch master updated: Use Java 11 for master branch

2021-04-06 Thread Apache
Can we not require a Jenkinsfile in each project that sets properties to control the behavior? Ralph > On Apr 6, 2021, at 6:45 AM, Matt Sicker wrote: > > Oops, good point. I need to make the version selection a little more > sophisticated. Probably a branch or something for the shared lib. >

Re: [logging-pipelines] branch master updated: Use Java 11 for master branch

2021-04-06 Thread Matt Sicker
Oops, good point. I need to make the version selection a little more sophisticated. Probably a branch or something for the shared lib. On Tue, Apr 6, 2021 at 01:56 Ralph Goers wrote: > I took care of the failure on verify. I added a clean to log4j-api so it > will clean every time. > > Ralph > >

Re: [logging-pipelines] branch master updated: Use Java 11 for master branch

2021-04-05 Thread Ralph Goers
I took care of the failure on verify. I added a clean to log4j-api so it will clean every time. Ralph > On Apr 5, 2021, at 10:55 PM, Ralph Goers wrote: > > Matt, > > A couple of comments > This doesn’t seem right. Log4j-audit, Kotlin, and Chainsaw all use the mvn > command. This will modify

Re: [logging-pipelines] branch master updated: Use Java 11 for master branch

2021-04-05 Thread Ralph Goers
Matt, A couple of comments This doesn’t seem right. Log4j-audit, Kotlin, and Chainsaw all use the mvn command. This will modify them to use Java 11 instead of Java 8. Did we really want to do that? The Jenkins build is still failing. The first phase that compiles works but the second phase that