I was talking about submitting a PR to the Cassandra project to add a
getter.
Gary
On Mon, Mar 14, 2022, 17:02 Piotr P. Karwasz
wrote:
> On Mon, Mar 14, 2022 at 9:47 PM Gary Gregory
> wrote:
> >
> > Time add a better to Cassandra in a PR! ;-)
>
> I took my chances pushing the commit directly a
If you're trying to test how CI handles a commit, then yeah, file a
PR. Those PR builds are the same as a commit build.
On Mon, Mar 14, 2022 at 4:02 PM Piotr P. Karwasz
wrote:
>
> On Mon, Mar 14, 2022 at 9:47 PM Gary Gregory wrote:
> >
> > Time add a better to Cassandra in a PR! ;-)
>
> I took m
On Mon, Mar 14, 2022 at 9:47 PM Gary Gregory wrote:
>
> Time add a better to Cassandra in a PR! ;-)
I took my chances pushing the commit directly and it failed on MacOS
(but retrieved the ephemeral port correctly), ;-(. Next time I'll opt
for a PR. Maybe the timeout is the issue. The MacOS machin
Time add a better to Cassandra in a PR! ;-)
Gary
On Mon, Mar 14, 2022, 15:31 Piotr P. Karwasz
wrote:
> On Mon, Mar 14, 2022 at 11:19 AM Gary Gregory
> wrote:
> > Using 0 to get an ephemeral is guaranteed to work (until the OS runs out
> of
> > ports). Using AvailablePortFinder does not guarant
On Mon, Mar 14, 2022 at 11:19 AM Gary Gregory wrote:
> Using 0 to get an ephemeral is guaranteed to work (until the OS runs out of
> ports). Using AvailablePortFinder does not guarantee anything IIRC. Isn't
> there a (small) chance that someone else on the machine can use that port
> before we do?
Using 0 to get an ephemeral is guaranteed to work (until the OS runs out of
ports). Using AvailablePortFinder does not guarantee anything IIRC. Isn't
there a (small) chance that someone else on the machine can use that port
before we do? Assuming there is an API that says 'this is my actual port'
i
Doh! I was responding to Gary's remark but after checking the diff in more
detail, indeed there are no fixed ports anywhere. On the contrary, this
commit addresses that issue.
On Mon, Mar 14, 2022 at 9:22 AM Piotr P. Karwasz
wrote:
> On Mon, Mar 14, 2022 at 1:18 AM Gary Gregory
> wrote:
> >
> >
On Mon, Mar 14, 2022 at 1:18 AM Gary Gregory wrote:
>
> Can't we use an ephemeral port here?
I am not sure I understand: `AvailablePortFinder` does return a port
in the ephemeral range.
Piotr
>
> Gary
>
> On Sun, Mar 13, 2022, 19:14 wrote:
>
> > This is an automated email from the ASF dual-hos
We indeed can and should!
Piotr, see `JsonTemplateLayoutNullEventDelimiterTest` and
`nullEventDelimitedJsonTemplateLayoutLogging.xml` for inspiration.
On Mon, Mar 14, 2022 at 1:18 AM Gary Gregory wrote:
> Can't we use an ephemeral port here?
>
> Gary
>
> On Sun, Mar 13, 2022, 19:14 wrote:
>
>
Can't we use an ephemeral port here?
Gary
On Sun, Mar 13, 2022, 19:14 wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> pkarwasz pushed a commit to branch release-2.x
> in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git
>
>
> The following commit
10 matches
Mail list logo
