Re: [logging-log4j2] branch master updated: Fix NPE in Log4jMarker

2022-12-25 Thread Gary Gregory
Thank you for the clarification, Piotr. I missed the fact that this is for slf4j. Gary On Sun, Dec 25, 2022 at 5:03 PM Piotr P. Karwasz wrote: > > Hi Gary, > > On Sun, 25 Dec 2022 at 22:53, Gary Gregory wrote: > > > > I think using Objects.requireNonNull() is more precise FWIW. > > I agree wit

Re: [logging-log4j2] branch master updated: Fix NPE in Log4jMarker

2022-12-25 Thread Piotr P. Karwasz
Hi Gary, On Sun, 25 Dec 2022 at 22:53, Gary Gregory wrote: > > I think using Objects.requireNonNull() is more precise FWIW. I agree with you, but Ceki's javadoc requires an IllegalArgumentException. Piotr

Re: [logging-log4j2] branch master updated: Fix NPE in Log4jMarker

2022-12-25 Thread Gary Gregory
I think using Objects.requireNonNull() is more precise FWIW. Gary On Sun, Dec 25, 2022, 16:38 wrote: > This is an automated email from the ASF dual-hosted git repository. > > pkarwasz pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git > > > T