Re: [log4j] Upgrade `2.x` compiler baseline to Java 17

2023-12-01 Thread Volkan Yazıcı
Done. Will port this to `main` next week. On Thu, Nov 30, 2023 at 5:03 PM Volkan Yazıcı wrote: > Heads up! #2021 > bumps the `2.x` baseline to Java 17. Everything works locally. If CI agrees > too, I will merge it tomorrow and start porting to

Re: [log4j] Upgrade `2.x` compiler baseline to Java 17

2023-11-30 Thread Matt Sicker
No, only that it requires Java 17 to build. It still targets the Java 8 release profile. > On Nov 30, 2023, at 11:15 AM, Gary Gregory wrote: > > Nice! That means that 2.23.0 will require Java 17 at runtime right? > > Gary > > > On Thu, Nov 30, 2023, 11:05 AM Volkan Yazıcı wrote: > >> Heads

Re: [log4j] Upgrade `2.x` compiler baseline to Java 17

2023-11-30 Thread Gary Gregory
Nice! That means that 2.23.0 will require Java 17 at runtime right? Gary On Thu, Nov 30, 2023, 11:05 AM Volkan Yazıcı wrote: > Heads up! #2021 bumps > the `2.x` baseline to Java 17. Everything works locally. If CI agrees too, > I will merge

Re: [log4j] Upgrade `2.x` compiler baseline to Java 17

2023-11-30 Thread Piotr P. Karwasz
Hi Matt, On Thu, 30 Nov 2023 at 18:09, Matt Sicker wrote: > > Sounds great! We even finally updated Spinnaker this week to build on Java > 17, so great timing. As far as I have seen most Commons build on JDK 21. This might however be too high for us, since tests using SecurityManager start to f

Re: [log4j] Upgrade `2.x` compiler baseline to Java 17

2023-11-30 Thread Matt Sicker
Sounds great! We even finally updated Spinnaker this week to build on Java 17, so great timing. — Matt Sicker > On Nov 30, 2023, at 10:03, Volkan Yazıcı wrote: > > Heads up! #2021 bumps > the `2.x` baseline to Java 17. Everything works locall

Re: [log4j] Upgrade `2.x` compiler baseline to Java 17

2023-11-30 Thread Piotr P. Karwasz
Hi Volkan, On Thu, 30 Nov 2023 at 17:05, Volkan Yazıcı wrote: > > Heads up! #2021 bumps > the `2.x` baseline to Java 17. Everything works locally. If CI agrees too, > I will merge it tomorrow and start porting to `main`. Nice job. This allows

[log4j] Upgrade `2.x` compiler baseline to Java 17

2023-11-30 Thread Volkan Yazıcı
Heads up! #2021 bumps the `2.x` baseline to Java 17. Everything works locally. If CI agrees too, I will merge it tomorrow and start porting to `main`.