Re: [log4j] New broken tests in master: LogstashIT

2022-06-23 Thread Volkan Yazıcı
I use the official Elasticsearch and Logstash Docker images to test if JTL+SocketAppender plays nicely with the ELK stack. These images are pretty big and require OS-specific configuration (e.g., upping the `nofile`) to run. I failed to convince Elastic to release more lightweight images to work ar

Re: [log4j] New broken tests in master: LogstashIT

2022-06-22 Thread Matt Sicker
What are you using for Docker integration tests? I've used Testcontainers for that for the past couple years, and it usually works fine on my machine. I do have Docker, though if the images are x86-only or something, I'm not able to run those without some finagling I think. You can use assumeTrue()

Re: [log4j] New broken tests in master: LogstashIT

2022-06-21 Thread Volkan Yazıcı
Docker-dependent ITs need to be disabled by default. I forgot to copy the skip=true snippet for maven-failsafe-plugin while merging LOG4J2-3502, i.e., JPMS support for JTL. I have also added notes to not forget it next time: Disable ITs, which are Docker-dependent, by default. Running Docker on al

[log4j] New broken tests in master: LogstashIT

2022-06-21 Thread Matt Sicker
These tests are failing on macOS with a connection error of some sort. Not sure if it fails on other operating systems, but it reliably fails early enough in the macOS builds to cancel the others, and it fails for me locally as well. Possible cause could be related to JUnit dependency updates if th