Re: [log4j] MongoDB driver 2.x vs. 3.x

2018-01-22 Thread Ralph Goers
Please don’t commit the mongo 3 stuff until we decide what to do. I really, really want Cassandra, Flume, Mongo and other lightly used components out of the main build. Ralph > On Jan 22, 2018, at 12:12 PM, Gary Gregory wrote: > > On Sun, Jan 21, 2018 at 11:43 PM, Gary Gregory

Re: [log4j] MongoDB driver 2.x vs. 3.x

2018-01-22 Thread Gary Gregory
On Sun, Jan 21, 2018 at 11:43 PM, Gary Gregory wrote: > On Sun, Jan 21, 2018 at 5:22 PM, Ralph Goers > wrote: > >> If the mongo 2 and mongo 3 Java 9 module names are going to be different >> then their package names must unique. JPMS requires that a Java package >> reside in only one module. >>

Re: [log4j] MongoDB driver 2.x vs. 3.x

2018-01-21 Thread Gary Gregory
On Sun, Jan 21, 2018 at 5:22 PM, Ralph Goers wrote: > If the mongo 2 and mongo 3 Java 9 module names are going to be different > then their package names must unique. JPMS requires that a Java package > reside in only one module. > > As a general rule, if you change the artifactId the package nam

Re: [log4j] MongoDB driver 2.x vs. 3.x

2018-01-21 Thread Ralph Goers
If the mongo 2 and mongo 3 Java 9 module names are going to be different then their package names must unique. JPMS requires that a Java package reside in only one module. As a general rule, if you change the artifactId the package name should be changed as well. I agree that it is probably be

Re: [log4j] MongoDB driver 2.x vs. 3.x

2018-01-21 Thread Gary Gregory
On Sun, Jan 21, 2018 at 4:20 PM, Ralph Goers wrote: > What do you mean by “renaming”? Hello, What I mean is that the Maven module's artifact ID 'log4j-mongodb' would be renamed to 'log4j-mongodb2' in the pom.xml file. The Java 9 module name in pom.xml would be adjusted as well. We could also

Re: [log4j] MongoDB driver 2.x vs. 3.x

2018-01-21 Thread Ralph Goers
What do you mean by “renaming”? I don’t know that it would be a good idea for both the Mongo 2 & 3 plugins to have the same plugin name. Although it is not likely they would ever be used together if they do it would be impossible to ever have both at the same time. Ralph > On Jan 21, 2018, at

[log4j] MongoDB driver 2.x vs. 3.x

2018-01-21 Thread Gary Gregory
Hi All: As I am working through https://issues.apache.org/jira/browse/LOG4J2-2205 to migrate from 2.x to 3.x APIs in the module log4j-mongodb, I am concerned that the changes are large enough as to break some older apps. I am sure I wouldn't hear about it until my customers complain. Therefore, I