Hi Thorsten,
Would you consider a PR that updated the failing tests with code to check
for the required programmes?
We could then output a failure message that informed the user why the test
does not work.
On Fri, Jul 17, 2020 at 8:57 PM Thorsten Schöning
wrote:
> Guten Tag Robert Middleton,
>
I guess I'm viewing this as an "optional" test - we know that the test
is going to fail(because e.g. we don't have gzip installed), so
there's no reason to run the test. If gzip is installed, then the
test should run and pass appropriately.
I definitely agree that developers should have all tests
Guten Tag Robert Middleton,
am Donnerstag, 16. Juli 2020 um 14:54 schrieben Sie:
> So perhaps the best solution is based a little bit off of Stephen's
> earlier PR(#18[1]), but instead of compiling out the code that depends
> on gzip we make the test more granular(one test for rolling zip, one
> t
On Thu, Jul 16, 2020 at 2:24 AM Thorsten Schöning wrote:
> Am I correct that you are using JDK 11 already? Because I'm running
> into problems when executing Maven in my UB 16.04 with JDK 8 setup a
> while ago.
>
Correct, Java 11 and Maven 3.6.3 for me. I'm on Debian 10, so Java 11
is readily av
Hi Ralph,
Change your current directory to the cmake build directory (the directory
with CMakeCache.txt) before running ctest.
On Thu, Jul 16, 2020 at 1:33 AM Ralph Goers
wrote:
> I found ctest at target/dependency/cmake/bin but when I run it I get
>
> No tests were found!!!
>
> I don’t see a d
Guten Tag Robert Middleton,
am Mittwoch, 15. Juli 2020 um 23:44 schrieben Sie:
> No, I used the release_prepare.sh to generate it, since it's my
> understanding that is the script that should do that.
It is, that means the site is not part of the release anymore after
removing the ANT-parts and i
> How did you create those archives? I guess you didn't use the created
> release_*-scripts, but "make dist dist-zip" again?
No, I used the release_prepare.sh to generate it, since it's my
understanding that is the script that should do that.
I'm not sure if the autotools still work at this point
I found ctest at target/dependency/cmake/bin but when I run it I get
No tests were found!!!
I don’t see a directory named “package” so I am assuming you meant something
else.
Ralph
> On Jul 14, 2020, at 11:56 PM, Stephen Webb wrote:
>
> Could you re-run that test by typing
>
> ctest -R str
Thanks, I hadn’t seen that page.
Ralph
> On Jul 15, 2020, at 1:28 AM, Thorsten Schöning wrote:
>
> Guten Tag Ralph Goers,
> am Mittwoch, 15. Juli 2020 um 08:36 schrieben Sie:
>
>> [...]That said, I don’t see anyplace on the log4cxx web site that
>> even states what platforms it supports.[...]
Guten Tag Stephen Webb,
am Mittwoch, 15. Juli 2020 um 05:54 schrieben Sie:
> Thorsten did not accept my pull request.
> https://github.com/apache/logging-log4cxx/pull/18
And I still won't, the necessary tools to make them succeed can easily
be provided for Windows as well:
> C:\Program Files (x8
Guten Tag Robert Middleton,
am Mittwoch, 15. Juli 2020 um 04:16 schrieben Sie:
> As of this point, do the zip/tar.gz files contain everything required for
> release? Is there anything that needs to be added? I want to try and help
> if there's something that's missing.
How did you create those
Guten Tag Ralph Goers,
am Mittwoch, 15. Juli 2020 um 08:36 schrieben Sie:
> [...]That said, I don’t see anyplace on the log4cxx web site that
> even states what platforms it supports.[...]
There's the following table, which at least gives some hints. Besides
that, we shouldn't start a new discuss
After adding that directory to the path as well as the corresponding apr-util
directory I was able to get the build to run. Everything successfully compiled
but I got 1 test failure.
Start 19: streamtestcase
19/60 Test #19: streamtestcase .***Exception: SegFault
2
Could you re-run that test by typing
ctest -R streamtestcase --output-on-failure
in the build directory (in package if you used maven to build)
On Wed, Jul 15, 2020 at 4:37 PM Ralph Goers
wrote:
> I should add that the while there is nothing that mandates the PMC require
> builds to pass to ap
I should add that the while there is nothing that mandates the PMC require
builds to pass to approve a release, it would be unusual to approve one where
building on supported platforms fail without understanding whether the test
failures are critical or not. That said, I don’t see anyplace on th
If 'brew install apr' does not put a link to that apr-1-config in a
directory on your path, src/cmake/Find*.cmake should be made to use 'brew
--prefix'.
Could you raise an issue please?
On Wed, Jul 15, 2020 at 4:22 PM Ralph Goers
wrote:
> Yes, it is at /usr/local/Cellar/apr/1.7.0/libexec/bin/
Yes, it is at /usr/local/Cellar/apr/1.7.0/libexec/bin/.
Ralph
> On Jul 14, 2020, at 11:14 PM, Stephen Webb wrote:
>
> Hi Ralph,
>
> Could you tell me if your Mac has the script "apr-1-config" installed?
>
> The src/cmake/FindApr.cmake in log4cxx expects the apr installation to
> create that s
Hi Ralph,
Could you tell me if your Mac has the script "apr-1-config" installed?
The src/cmake/FindApr.cmake in log4cxx expects the apr installation to
create that script and it calls it (passing --includedir) to
set APR_INCLUDE_DIR with the output
On Wed, Jul 15, 2020 at 3:57 PM Ralph Goers
wr
I don’t see anything wrong with those files. They are the same two archives
provided in the last release.
I tried building them on my Mac but it gets an error
CMake Error at
target/dependency/cmake/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146
(message):
APR_INCLUDE_DIR
Hi Robert,
I believe the failures are due to gzip,sed and zip programs not being
available.
My preference was to exclude those tests when the program was not available
to prevent exactly the problem you encountered.
Thorsten did not accept my pull request.
https://github.com/apache/logging-log4c
I went and tested the current version of log4cxx, and at least on Linux I
don't have any failures. There are a bunch of failures on the Windows
side, but I don't know enough about windows to know where to start to debug
those.
The tests that failed:
90% tests passed, 6 tests failed out of 60
Tot
21 matches
Mail list logo
