Guten Tag Robert Middleton,
am Montag, 29. November 2021 um 04:53 schrieben Sie:
> At this point, I believe that I have converted all of the important
> classes to be ABI-stable.[...]
Not that it's too representative, but things properly build and test
for my pretty current VS 17.02 as well.
> A
At this point, I believe that I have converted all of the important
classes to be ABI-stable. There are a few that I have missed, some
probably unintentional, some because I plan on removing them. There
are also a handful of classes that don't need to be(nor perhaps should
be) ABI-stable - I'm th
Guten Tag Robert Middleton,
am Sonntag, 7. November 2021 um 17:36 schrieben Sie:
> I don't see any advantage to this over a macro, unless you were
> thinking of something else?
That's exactly what I meant and the benefits I see are simply avoiding
a macro and having something documented for the c
I think I see what you're saying now. We can do something like this:
class A{
virtual APrivate* private_data(){
return priv.get();
}
unique_ptr priv;
};
class B: public A{
virtual BPrivate* private_data(){
return static_cast(priv.get());
}
};
I don't see any advantage to this
Guten Tag Robert Middleton,
am Samstag, 6. November 2021 um 16:52 schrieben Sie:
> Unfortunately not, for the reasons above. Since the parent class only
> holds a single pointer to the private data, whatever data is stored
> must be a subclass of the parent's private data. So we must cast it
> t
> Great work! Is there something I should specifically look out when
> testing or would it be fione to know if things run at all already?
>
Mostly just looking for anything obvious that I may have missed, or
concerns with the implementation.
> Get a lot of warnings like this one currently:
>
> >
Guten Tag Robert Middleton,
am Samstag, 6. November 2021 um 02:57 schrieben Sie:
> There are some notes on how this is done here:
> https://github.com/apache/logging-log4cxx/blob/LOGCXX-510/src/site/markdown/library-design.md
Great work! Is there something I should specifically look out when
test
I've been working on making log4cxx ABI stable, and I believe that I
have converted most(if not all) classes at this point to be stable.
I've got a branch here that has all of the changes:
https://github.com/apache/logging-log4cxx/tree/LOGCXX-510
There are some notes on how this is done here:
http
