+1 from me, if there are issues on java 11 we can release another build. I
agree that we should put some time into getting CI running on both minimum and
maximum supported jvms, but that doesn't need to block this release. I have no
reason to believe that 2.12.0 has regressed from 2.11.2, and I
Oops. I jumped the gun. There are still a little less than 8 hours before 72
hours will have elapsed.
Ralph
> On Jun 28, 2019, at 12:47 PM, Ralph Goers wrote:
>
> For the record, here is my +1. 72 hours has elapsed but one more vote is
> needed for the release to proceed.
>
> Ralph
>
>> On
For the record, here is my +1. 72 hours has elapsed but one more vote is
needed for the release to proceed.
Ralph
> On Jun 25, 2019, at 8:59 PM, Ralph Goers wrote:
>
> This is a vote to release Log4j 2.12.0, the next version of the Log4j 2
> project.
>
> Please download, test, and cast your
I made it a JUnit assume so it would ignore the test when the class
isn't found. I think I made a Hamcrest matcher for it.
On Wed, 26 Jun 2019 at 23:04, Ralph Goers wrote:
>
> I tried porting the changes you made back to release-2.x and it compiles, but
> it still fails in the unit tests as the
I tried porting the changes you made back to release-2.x and it compiles, but
it still fails in the unit tests as the reflection fails since the class isn’t
present. How did you solve that?
Ralph
> On Jun 26, 2019, at 1:12 PM, Ralph Goers wrote:
>
> Nevermind. I see you used reflection. I am
I have fixed the module so that the rat plugin now runs. It had one file with a
license problem - a log4j2.xml used by the sample server. Although the sample
server is included in the source release it is not deployed to Nexus. Since it
is just a sample I don’t feel it warrants spinning a new re
Nevermind. I see you used reflection. I am not sure why I hadn’t thought of
doing that.
Ralph
> On Jun 26, 2019, at 1:08 PM, Ralph Goers wrote:
>
> How did you get around the compile problem in master?
>
> Ralph
>
>> On Jun 26, 2019, at 12:36 PM, Matt Sicker wrote:
>>
>> I fixed that sun.
How did you get around the compile problem in master?
Ralph
> On Jun 26, 2019, at 12:36 PM, Matt Sicker wrote:
>
> I fixed that sun.reflect compile error in master, but didn't backport
> it to release-2.x. There are still some other compile errors besides
> if you compile with Java 11.
>
> As
I fixed that sun.reflect compile error in master, but didn't backport
it to release-2.x. There are still some other compile errors besides
if you compile with Java 11.
As for why you get different results when running rat with or without
the rat profile activated, it's because our rat config is di
I have wondered that for a long time. In fact, if you run “mvn compile”
followed by “mvn test” you will see
[INFO] Changes detected - recompiling the module!
So obviously something is there that tries to detect changes. It just doesn’t
seem to work.
Ralph
> On Jun 26, 2019, at 9:32 AM, Gar
On Wed, Jun 26, 2019 at 12:24 PM Ralph Goers
wrote:
> Those are mine as well.
>
> Unfortunately, if you use the toolchains plugin to specify the compiler
> version then all the tests are also going to run with that Java version.
> Since there is no getting around having sun.reflect.Reflection be
Those are mine as well.
Unfortunately, if you use the toolchains plugin to specify the compiler version
then all the tests are also going to run with that Java version. Since there is
no getting around having sun.reflect.Reflection be used prior to Java 9 there
is no way to use Java 11 to comp
On Wed, Jun 26, 2019 at 11:02 AM Ralph Goers
wrote:
> I don’t run the build with Java 11, although I do have projects that use
> it that are on Java 11. It seems that log4j-api is failing when compiling
> with Java 11 because sun.reflect.Reflection was removed in Java 9. I guess
> we need to mod
I don’t run the build with Java 11, although I do have projects that use it
that are on Java 11. It seems that log4j-api is failing when compiling with
Java 11 because sun.reflect.Reflection was removed in Java 9. I guess we need
to modify the toolchains configuration to tell the main modules t
It occurs to me that the module that is failing for you is a Spring Boot app so
it inherits from Spring Boot parent. So when I run mvn -P rat clean verify it
won’t run rat because that module doesn’t have a rat plugin defined. When you
run apache-rat:check it will fail because you explicitly tol
Driving me nuts: I can do the following OK on Java 8: " mvn -P rat
-DskipTests clean install".
But then I switch to Java 11 and run "mvn test" and Maven wants to
recompile everything and fails as noted below.
How do you test on Java 11?
Gary
On Wed, Jun 26, 2019 at 10:24 AM Gary Gregory
wrote:
Note: Compiling on Java 11 fails:
[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @
log4j-api ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 84 source files to
C:\temp\rc\logging-log4j2\log4j-api\target\test-classes
[INFO] --
On Wed, Jun 26, 2019 at 9:08 AM Ralph Goers
wrote:
> That is interesting. As part of the pre-release process I run mvn -P rat
> -DskipTests clean verify and that succeeded.
>
Your command works for me as well, no surprise and a good thing. But
replacing '-P rat' with 'apache-rat:check' in that c
+1
The mongodb tests hung for me, but if I skip those, the tests pass.
On Wed, Jun 26, 2019 at 10:08 PM Ralph Goers
wrote:
> That is interesting. As part of the pre-release process I run mvn -P rat
> -DskipTests clean verify and that succeeded.
>
> Ralph
>
> > On Jun 26, 2019, at 5:58 AM, Gary
That is interesting. As part of the pre-release process I run mvn -P rat
-DskipTests clean verify and that succeeded.
Ralph
> On Jun 26, 2019, at 5:58 AM, Gary Gregory wrote:
>
> On Wed, Jun 26, 2019 at 8:40 AM Gary Gregory wrote:
>
>> FYI, running 'mvn apache-rat:check' fails on log4j-cassa
Please note these nits as TODOs, the following Maven module descriptions
should start with "Apache Log4j" like all the other modules:
[INFO] Log4j Sample Configuration Service . FAILURE [
1.429 s]
[INFO] Spring Cloud Config Sample Application . SKIPPED
Gary
On Wed,
On Wed, Jun 26, 2019 at 8:40 AM Gary Gregory wrote:
> FYI, running 'mvn apache-rat:check' fails on log4j-cassandra/.toDelete
>
Ah, I can see that we have .gitignore set up to ignore this file so I
deleted it and ran 'mvn apache-rat:check' again and got:
[INFO] --<
org.apache.logging.log4j.sampl
FYI, running 'mvn apache-rat:check' fails on log4j-cassandra/.toDelete
Gary
On Tue, Jun 25, 2019 at 11:59 PM Ralph Goers
wrote:
> This is a vote to release Log4j 2.12.0, the next version of the Log4j 2
> project.
>
> Please download, test, and cast your votes on the log4j developers list.
> []
This is a vote to release Log4j 2.12.0, the next version of the Log4j 2 project.
Please download, test, and cast your votes on the log4j developers list.
[] +1, release the artifacts
[] -1, don't release because...
The vote will remain open for 72 hours (or more if required). All votes are
welco
24 matches
Mail list logo
