Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-22 Thread Ralph Goers
Here is my +1 Ralph > On Nov 20, 2017, at 10:38 PM, Ralph Goers wrote: > > I have fixed the page on my GitHub site. > > Ralph > >> On Nov 20, 2017, at 7:36 PM, Remko Popma wrote: >> >> +1 >> checksums good, build good, site good other than H3 on top page. >> >> On Tue, Nov 21, 2017 at 5:41

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Ralph Goers
I have fixed the page on my GitHub site. Ralph > On Nov 20, 2017, at 7:36 PM, Remko Popma wrote: > > +1 > checksums good, build good, site good other than H3 on top page. > > On Tue, Nov 21, 2017 at 5:41 AM, Matt Sicker wrote: > >> FWIW, if I have to download and compile the source code for

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Remko Popma
+1 checksums good, build good, site good other than H3 on top page. On Tue, Nov 21, 2017 at 5:41 AM, Matt Sicker wrote: > FWIW, if I have to download and compile the source code for Java libraries, > I usually just skip tests. > > On 20 November 2017 at 13:50, Ralph Goers > wrote: > > > More li

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Matt Sicker
FWIW, if I have to download and compile the source code for Java libraries, I usually just skip tests. On 20 November 2017 at 13:50, Ralph Goers wrote: > More like 4 hors > > Sent from my iPhone > > > On Nov 20, 2017, at 12:43 PM, Mikael Ståldal wrote: > > > > It is. But how common is it that p

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Ralph Goers
More like 4 hors Sent from my iPhone > On Nov 20, 2017, at 12:43 PM, Mikael Ståldal wrote: > > It is. But how common is it that people download the source of a particular > release? I think that most people either download the binary artifacts, or > build the source from latest master branch

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Mikael Ståldal
It is. But how common is it that people download the source of a particular release? I think that most people either download the binary artifacts, or build the source from latest master branch (and there it is already fixed). Maybe we can include something about this in the release notes, tha

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Gary Gregory
It's just lame that if someone downloads the source they cannot even build it :-( Gayr On Mon, Nov 20, 2017 at 2:28 PM, Mikael Ståldal wrote: > I agree with Ralph. > > On 2017-11-20 20:03, Ralph Goers wrote: > >> Unless you find something else I am not inclined to rerun the release >> just to f

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Mikael Ståldal
I agree with Ralph. On 2017-11-20 20:03, Ralph Goers wrote: Unless you find something else I am not inclined to rerun the release just to fix a unit test where we know what the problem is and that has no impact on the code customers use. Ralph On Nov 20, 2017, at 11:56 AM, Gary Gregory wro

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Ralph Goers
Unless you find something else I am not inclined to rerun the release just to fix a unit test where we know what the problem is and that has no impact on the code customers use. Ralph > On Nov 20, 2017, at 11:56 AM, Gary Gregory wrote: > > On Mon, Nov 20, 2017 at 10:43 AM, Gary Gregory > wro

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Gary Gregory
On Mon, Nov 20, 2017 at 10:43 AM, Gary Gregory wrote: > Here it is: > > [ERROR] Tests run: 13, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 1.469 s <<< FAILURE! - in org.apache.log4j.config. > Log4j1ConfigurationFactoryTest > [ERROR] testSystemProperties1(org.apache.log4j.config. > Log4j1C

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Ralph Goers
We get this error from time to time in Jenkins. It seems to happen more often in Windows. As far as I am concerned this is another error we can ignore for the purposes of the release. Ralph > On Nov 20, 2017, at 10:43 AM, Gary Gregory wrote: > > Here it is: > > [ERROR] Tests run: 13, Failure

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Gary Gregory
Here it is: [ERROR] Tests run: 13, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.469 s <<< FAILURE! - in org.apache.log4j.config.Log4j1ConfigurationFactoryTest [ERROR] testSystemProperties1(org.apache.log4j.config.Log4j1ConfigurationFactoryTest) Time elapsed: 0.027 s <<< ERROR! java.nio.fil

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Gary Gregory
AFK sorry On Nov 20, 2017 12:19, "Mikael Ståldal" wrote: Is that the complete error message? On 2017-11-20 17:41, Gary Gregory wrote: > Now I get a different failure. I had run the build in Windows but from the > git command line (MINGW64). That that I run from a "real" Windows command > lin

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Mikael Ståldal
Is that the complete error message? On 2017-11-20 17:41, Gary Gregory wrote: Now I get a different failure. I had run the build in Windows but from the git command line (MINGW64). That that I run from a "real" Windows command line I get: [ERROR] Errors: [ERROR] Log4j1ConfigurationFactoryTest

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Gary Gregory
Wow, Now I get a different failure. I had run the build in Windows but from the git command line (MINGW64). That that I run from a "real" Windows command line I get: [ERROR] Errors: [ERROR] Log4j1ConfigurationFactoryTest.testSystemProperties1:173 » FileSystem C:\Users... [INFO] [ERROR] Tests ru

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Ralph Goers
I can manually fix the html before the site is published if needed. Ralph > On Nov 20, 2017, at 8:42 AM, Matt Sicker wrote: > > +1 > > Signatures good. Works with my tested projects. Site looks mostly good, > though there's an errant "h3" in the index page. Could be more site things, > though

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Matt Sicker
+1 Signatures good. Works with my tested projects. Site looks mostly good, though there's an errant "h3" in the index page. Could be more site things, though they can all be applied after a release. On 20 November 2017 at 07:36, Daan Hoogland wrote: > Checked out and ran mvn clean install, next

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Daan Hoogland
Checked out and ran mvn clean install, next I updated my experimental pom.xml for cloudstack and did a mvn clean install. No errors to see so +1. Nice work people, congrats so far and thanks. On 20/11/2017, 14:37, "Apache" wrote: The fact that you can’t see a difference is why I think it i

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Apache
The fact that you can’t see a difference is why I think it is a code page issue and also why I think the failure is insignificant to the release. Ralph > On Nov 20, 2017, at 4:40 AM, Remko Popma wrote: > > Ran another build from the release tag, with Java 7. Build succeeds. > > I'll look at t

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Remko Popma
Ran another build from the release tag, with Java 7. Build succeeds. I'll look at the checksums and the site next. Gary, could you run another clean build? The error messages look strange: I cannot see any difference between the expected and the actual result in the error output... Apache Mave

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-20 Thread Remko Popma
> On Nov 20, 2017, at 15:21, Ralph Goers wrote: > > Oh, and I wouldn’t be surprised if the problem is caused by you using MS932 > and Greg using cp1252. From Gary’s error messages it seems more like a white space/newline issue which is odd because it works on my Windows and the tests use St

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Ralph Goers
Oops - Greg s/b Gary. Ralph > On Nov 19, 2017, at 11:21 PM, Ralph Goers wrote: > > Oh, and I wouldn’t be surprised if the problem is caused by you using MS932 > and Greg using cp1252. > > Ralph > > >> On Nov 19, 2017, at 11:12 PM, Remko Popma wrote: >> >> Building current master (211326b)

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Ralph Goers
Oh, and I wouldn’t be surprised if the problem is caused by you using MS932 and Greg using cp1252. Ralph > On Nov 19, 2017, at 11:12 PM, Remko Popma wrote: > > Building current master (211326b) succeeds for me when running `mvn clean > verify` on > > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Ralph Goers
Can you test the release candidate? If you do you might as well vote on it. Ralph > On Nov 19, 2017, at 11:12 PM, Remko Popma wrote: > > Building current master (211326b) succeeds for me when running `mvn clean > verify` on > > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; > 20

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Remko Popma
Building current master (211326b) succeeds for me when running `mvn clean verify` on Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T01:41:47+09:00) Maven home: C:\apps\apache-maven-3.3.9\bin\.. Java version: 1.8.0_131, vendor: Oracle Corporation Java home: C:\apps\jdk1.8.

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Remko Popma
When I upgraded picocli to 2.0.3 a few weeks ago I made sure all tests passed on Windows. CI builds are ok. I also did a successful Log4j2 build on Windows yesterday when looking at pull request #134. This is very odd. > On Nov 20, 2017, at 12:49, Ralph Goers wrote: > > All of these erro

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Ralph Goers
All of these errors seem to be against a single test class which tests the help text of the command line tool. Frankly, I don’t even know what that tool does. Second, I’ve not had any problems on MacOS nor seem complaints on Linux. Have you run a full build on Windows since JCommander replaced P

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Gary Gregory
-1 >From src zip: ASC OK, MD5 OK, SHA1 OK. Building with 'mvn clean verify' using: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T03:58:13-04:00) Maven home: C:\Java\apache-maven-3.5.2 Java version: *1.7.0_80*, vendor: *Oracle* Corporation Java home: C:\Program Files\Ja

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Gary Gregory
FTR, it would be good to note the svn revision of svn links. Gary On Sun, Nov 19, 2017 at 11:11 AM, Ralph Goers wrote: > This is a vote to release Log4j 2.10.0, the next version of the Log4j 2 > project. > > Please download, test, and cast your votes on the log4j developers list. > [] +1, relea

Re: [VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Mikael Ståldal
+1 * Maven artifacts works in my test project. * Build of tags/log4j-2.10-rc1 works. On 2017-11-19 19:11, Ralph Goers wrote: This is a vote to release Log4j 2.10.0, the next version of the Log4j 2 project. Please download, test, and cast your votes on the log4j developers list. [] +1, release

[VOTE] Release Log4j 2.10.0-rc1

2017-11-19 Thread Ralph Goers
This is a vote to release Log4j 2.10.0, the next version of the Log4j 2 project. Please download, test, and cast your votes on the log4j developers list. [] +1, release the artifacts [] -1, don't release because... The vote will remain open for 72 hours (or more if required). All votes are welco