Re: [VOTE] Release Apache Log4j Tools 0.6.0 (RC2)

2023-11-20 Thread Volkan Yazıcı
Adding my +1. With that, the release passes with 3 binding +1 votes from Piotr, Gary, and myself. I will continue the release process. On Fri, Nov 17, 2023 at 10:21 AM Volkan Yazıcı wrote: > > This is a vote to release the Apache Log4j Tools 0.6.0 (RC2). > > Website: https://logging.staged.apach

Re: [VOTE] Release Apache Log4j Tools 0.6.0

2023-11-17 Thread Volkan Yazıcı
`log4j-tools-bom:0.5.0` is broken: `parent` is missing. This release (i.e., `0.6.0`) fixes that. On Fri, Nov 17, 2023 at 2:11 PM Gary D. Gregory wrote: > > Seen during 'mvn clean verify' > > [INFO] --- log4j-changelog:0.5.0:export (export-changelog) @ log4j-tools-bom > --- > [WARNING] The POM fo

Re: [VOTE] Release Apache Log4j Tools 0.6.0

2023-11-17 Thread Volkan Yazıcı
Good catch. Though not a big issue; `spotbugs-annotations` dependency is missing. Fixed in `main` via `fb6fee27b349bb7ec5e847a6d33f9abb81b714ec`. On Fri, Nov 17, 2023 at 2:12 PM Gary D. Gregory wrote: > > Also seen during 'mvn clean verify': > > [INFO] --- compiler:3.11.0:compile (default-compile

Re: [VOTE] Release Apache Log4j Tools 0.6.0 (RC2)

2023-11-17 Thread Gary D. Gregory
+1 Same warnings as noted previously. - Testing src zip file - OK: ASC verify - OK: SHA check - OK: mvn clean verify Using: Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546) Maven home: C:\java\apache-maven-3.9.5 Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program F

Re: [VOTE] Release Apache Log4j Tools 0.6.0

2023-11-17 Thread Gary D. Gregory
Also seen during 'mvn clean verify': [INFO] --- compiler:3.11.0:compile (default-compile) @ log4j-changelog-maven-plugin --- [INFO] Changes detected - recompiling the module! :dependency [INFO] Compiling 5 source files with javac [debug release 8] to target\classes [WARNING] Cannot find annotatio

Re: [VOTE] Release Apache Log4j Tools 0.6.0

2023-11-17 Thread Gary D. Gregory
Seen during 'mvn clean verify' [INFO] --- log4j-changelog:0.5.0:export (export-changelog) @ log4j-tools-bom --- [WARNING] The POM for org.apache.logging.log4j:log4j-changelog:jar:0.5.0 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details expor

Re: [VOTE] Release Apache Log4j Tools 0.6.0 (RC2)

2023-11-17 Thread Piotr P. Karwasz
Hi Volkan, On Fri, 17 Nov 2023 at 10:21, Volkan Yazıcı wrote: > Please download, test, and cast your votes on this mailing list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... I have rechecked: * the hashes of all artifacts against locally generated ones, * the hashes an

Re: [VOTE] Release Apache Log4j Tools 0.6.0 (RC2)

2023-11-17 Thread Piotr P. Karwasz
Hi Volkan, On Fri, 17 Nov 2023 at 10:21, Volkan Yazıcı wrote: > This vote is open for 24 hours and will pass unless getting a > net negative vote count. All votes are welcome and we encourage > everyone to test the release, but only the Logging Services PMC > votes are officially counted. At leas

[VOTE] Release Apache Log4j Tools 0.6.0 (RC2)

2023-11-17 Thread Volkan Yazıcı
This is a vote to release the Apache Log4j Tools 0.6.0 (RC2). Website: https://logging.staged.apache.org/log4j/tools GitHub: https://github.com/apache/logging-log4j-tools Commit: a696e081304cc0693d86533013df5b4d886cfb9c Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j-tools Nexus

Re: [VOTE] Release Apache Log4j Tools 0.6.0

2023-11-17 Thread Volkan Yazıcı
Doh! As you stated [in your DM], `build.yaml` still contains the deprecated `distribution-attachment-filepath-pattern`, which doesn't match against SBOMs. I am cancelling this vote. I will issue an RC2 promptly. On Fri, Nov 17, 2023 at 9:36 AM Piotr P. Karwasz wrote: > > Hi Volkan, > > On Fri, 1

Re: [VOTE] Release Apache Log4j Tools 0.6.0

2023-11-17 Thread Piotr P. Karwasz
Hi Volkan, On Fri, 17 Nov 2023 at 09:22, Volkan Yazıcı wrote: > > They are. See `*-bin.zip`. > > On Fri, Nov 17, 2023 at 9:13 AM Christian Grobmeier > wrote: > > > > Should the SBOM/CycloneDX files be part of the distribution folder as well? > > https://dist.apache.org/repos/dist/dev/logging/log

Re: [VOTE] Release Apache Log4j Tools 0.6.0

2023-11-17 Thread Volkan Yazıcı
They are. See `*-bin.zip`. On Fri, Nov 17, 2023 at 9:13 AM Christian Grobmeier wrote: > > Should the SBOM/CycloneDX files be part of the distribution folder as well? > https://dist.apache.org/repos/dist/dev/logging/log4j-tools/ > > > On Wed, Nov 15, 2023, at 16:03, Volkan Yazıcı wrote: > > This i

Re: [VOTE] Release Apache Log4j Tools 0.6.0

2023-11-17 Thread Christian Grobmeier
Should the SBOM/CycloneDX files be part of the distribution folder as well? https://dist.apache.org/repos/dist/dev/logging/log4j-tools/ On Wed, Nov 15, 2023, at 16:03, Volkan Yazıcı wrote: > This is a vote to release the Apache Log4j Tools 0.6.0. > > Website: https://logging.staged.apache.org/log

Re: [VOTE] Release Apache Log4j Tools 0.6.0

2023-11-16 Thread Piotr P. Karwasz
Hi Volkan, On Wed, 15 Nov 2023 at 16:10, Volkan Yazıcı wrote: > > This is a vote to release the Apache Log4j Tools 0.6.0. > > Website: https://logging.staged.apache.org/log4j/tools > GitHub: https://github.com/apache/logging-log4j-tools > Commit: 18425d95a4d150de905929d55bf55545d70f3d91 > Distrib

[VOTE] Release Apache Log4j Tools 0.6.0

2023-11-15 Thread Volkan Yazıcı
This is a vote to release the Apache Log4j Tools 0.6.0. Website: https://logging.staged.apache.org/log4j/tools GitHub: https://github.com/apache/logging-log4j-tools Commit: 18425d95a4d150de905929d55bf55545d70f3d91 Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j-tools Nexus: http