Re: [VOTE] Release Apache Log4j Tools 0.3.0

2023-03-17 Thread Volkan Yazıcı
Adding my +1. With that, the release passes with 3 binding +1 votes from me, Piotr, and Matt. (I will address Gary's Windows-related issues either in the mailing list or in Slack.) On Tue, Mar 14, 2023 at 10:08 PM Volkan Yazıcı wrote: > The Apache Log4j Tools 0.3.0 release is now available for

Re: [VOTE] Release Apache Log4j Tools 0.3.0

2023-03-16 Thread Benoit Lacelle
We may also tweak the lineEndings parameter based on a profile ( https://github.com/diffplug/spotless/tree/main/plugin-gradle#line-endings-and-encodings-invisible-stuff ) (instead of dropping the whole plugin) Benoit Le jeu. 16 mars 2023 à 10:48, Piotr P. Karwasz a écrit : > Hi Ralph, > > On We

Re: [VOTE] Release Apache Log4j Tools 0.3.0

2023-03-15 Thread Piotr P. Karwasz
Hi Ralph, On Wed, 15 Mar 2023 at 23:59, Ralph Goers wrote: > > Just require the build to run on a Unix-like variant. Nobody is going to give > a crap that the tools don’t build on Windows. At least Gary does. On the other hand nobody gives a crap that Spotless does not work on the source distr

Re: [VOTE] Release Apache Log4j Tools 0.3.0

2023-03-15 Thread Ralph Goers
Just require the build to run on a Unix-like variant. Nobody is going to give a crap that the tools don’t build on Windows. Ralph > On Mar 15, 2023, at 3:16 PM, Piotr P. Karwasz wrote: > > Hi Gary, > > On Wed, 15 Mar 2023 at 22:58, Gary D. Gregory wrote: >> [INFO] --- spotless:2.35.0:check (

Re: [VOTE] Release Apache Log4j Tools 0.3.0

2023-03-15 Thread Matt Sicker
Latest version of Notepad probably supports line feed endings these days as it is. > On Mar 15, 2023, at 5:16 PM, Piotr P. Karwasz wrote: > > Hi Gary, > > On Wed, 15 Mar 2023 at 22:58, Gary D. Gregory wrote: >> [INFO] --- spotless:2.35.0:check (default-spotless) @ log4j-changelog --- >> [INFO

Re: [VOTE] Release Apache Log4j Tools 0.3.0

2023-03-15 Thread Piotr P. Karwasz
Hi Gary, On Wed, 15 Mar 2023 at 22:58, Gary D. Gregory wrote: > [INFO] --- spotless:2.35.0:check (default-spotless) @ log4j-changelog --- > [INFO] Index file does not exist. Fallback to an empty index > [INFO] Spotless.Java is keeping 24 files clean - 24 needs changes to be > clean, 0 were alrea

Re: [VOTE] Release Apache Log4j Tools 0.3.0

2023-03-15 Thread Gary D. Gregory
Based on the src zip download: (Please see my notes below for 1 improvement to the sha file) mvn clean verify Gives me: [INFO] --- spotless:2.35.0:check (default-spotless) @ log4j-changelog --- [INFO] Index file does not exist. Fallback to an empty index [INFO] Spotless.Java is keeping 24 files

Re: [VOTE] Release Apache Log4j Tools 0.3.0

2023-03-15 Thread Gary D. Gregory
On 2023/03/15 21:46:10 "Gary D. Gregory" wrote: > IMO, VOTE emails should contain a link to the appropriate KEYS file. FTR: https://downloads.apache.org/logging/KEYS Gary > > Gary > > On 2023/03/14 21:08:39 Volkan Yazıcı wrote: > > The Apache Log4j Tools 0.3.0 release is now available for voti

Re: [VOTE] Release Apache Log4j Tools 0.3.0

2023-03-15 Thread Gary D. Gregory
IMO, VOTE emails should contain a link to the appropriate KEYS file. Gary On 2023/03/14 21:08:39 Volkan Yazıcı wrote: > The Apache Log4j Tools 0.3.0 release is now available for voting. > > This release contains the following minor enhancements: > > * Upgrade the compiler version to Java 17, ye

Re: [VOTE] Release Apache Log4j Tools 0.3.0

2023-03-15 Thread Gary D. Gregory
There are still 0.2.0 files in /dev/logging/log4j ! Delete please. Gary On 2023/03/14 21:08:39 Volkan Yazıcı wrote: > The Apache Log4j Tools 0.3.0 release is now available for voting. > > This release contains the following minor enhancements: > > * Upgrade the compiler version to Java 17, yet

Re: [VOTE] Release Apache Log4j Tools 0.3.0

2023-03-15 Thread Gary D. Gregory
Arg, I downloaded the wrong files. Ralph and all RMs: Please delete files post release from /dev/logging/log4j Gary On 2023/03/14 21:08:39 Volkan Yazıcı wrote: > The Apache Log4j Tools 0.3.0 release is now available for voting. > > This release contains the following minor enhancements: > > *

Re: [VOTE] Release Apache Log4j Tools 0.3.0

2023-03-15 Thread Gary D. Gregory
Hi All, I do not think we should clutter things up by publishing two sets of SHA files (256 & 512), SHA-512 only is plenty IMO. Gary On 2023/03/14 21:08:39 Volkan Yazıcı wrote: > The Apache Log4j Tools 0.3.0 release is now available for voting. > > This release contains the following minor enh

Re: [VOTE] Release Apache Log4j Tools 0.3.0

2023-03-15 Thread Matt Sicker
Took me a few tries to find the right JDK to use (17), but everything checks out fine. +1 > On Mar 14, 2023, at 4:08 PM, Volkan Yazıcı wrote: > > The Apache Log4j Tools 0.3.0 release is now available for voting. > > This release contains the following minor enhancements: > > * Upgrade the com

Re: [VOTE] Release Apache Log4j Tools 0.3.0

2023-03-15 Thread Piotr P. Karwasz
Hi Volkan, On Tue, 14 Mar 2023 at 22:08, Volkan Yazıcı wrote: > > The Apache Log4j Tools 0.3.0 release is now available for voting. > > This release contains the following minor enhancements: > > * Upgrade the compiler version to Java 17, yet still target Java 8 > * Support multiple and formattin

[VOTE] Release Apache Log4j Tools 0.3.0

2023-03-14 Thread Volkan Yazıcı
The Apache Log4j Tools 0.3.0 release is now available for voting. This release contains the following minor enhancements: * Upgrade the compiler version to Java 17, yet still target Java 8 * Support multiple and formatting-agnostic template files (#44) * The changelog release models passed to the