Re: [VOTE] Release Apache Log4j Tools 0.2.0

2023-02-02 Thread Volkan Yazıcı
Adding my +1. With that, the release passes with 3 binding +1 votes from me, Piotr, and Ralph. (Gary, I will address your concerns in another thread.) On Tue, Jan 31, 2023 at 6:19 PM Volkan Yazıcı wrote: > > The Apache Log4j Tools 0.2.0 release is now available for voting. > > This release cont

Re: [VOTE] Release Apache Log4j Tools 0.2.0

2023-02-02 Thread Ralph Goers
Yes, the tools require Java 11 to build. That should have been obvious by the “Unrecognized option: —add exports” message. Ralph > On Feb 2, 2023, at 7:53 PM, Gary Gregory wrote: > > Warning: I am frustrated. > > I'm not going to -1 this but I'm not going to +1 because it is a giant > pain to

Re: [VOTE] Release Apache Log4j Tools 0.2.0

2023-02-02 Thread Gary Gregory
Warning: I am frustrated. I'm not going to -1 this but I'm not going to +1 because it is a giant pain to build without deleting a bunch of files from the source zip file. There are HIDDEN and not hidden Maven files/folders in there? Why? I f*k hate it when downloads try to take over my tooling.

Re: [VOTE] Release Apache Log4j Tools 0.2.0

2023-02-02 Thread Gary Gregory
Another minor note: Doubling SHA checksums seems over-the-top in https://dist.apache.org/repos/dist/dev/logging/log4j/ I'd stick to 512. Gary On Tue, Jan 31, 2023 at 12:18 PM Volkan Yazıcı wrote: > > The Apache Log4j Tools 0.2.0 release is now available for voting. > > This release contains the

Re: [VOTE] Release Apache Log4j Tools 0.2.0

2023-02-02 Thread Gary Gregory
A minor note: The tags don't look to me like they are named properly. In other projects, I see and do, for example: someartifact-1.0.2-rc1 is the tag for an RC rel/someartifact-1.0.2 is the tag for the release where infra makes rel/ tags read-only, at least I'm pretty sure they do. Having a tag f

Re: [VOTE] Release Apache Log4j Tools 0.2.0

2023-02-01 Thread Ralph Goers
+1 Verified signature and checksum. Also verified the Maven plugins work with Log4j 2. One note however, is that the signing key used has not has note been signed by any of us so isn’t exactly trustworthy. We all should sign the key. Ralph > On Jan 31, 2023, at 10:19 AM, Volkan Yazıcı wrote

Re: [VOTE] Release Apache Log4j Tools 0.2.0

2023-01-31 Thread Volkan Yazıcı
Very sharp of you Piotr! Thanks for reviewing the changes thoroughly. `0.1.0` in the XSD is not a mistake. I used different versions for the XSD, which resembles more of an API, and the project itself, since they are independent. On Tue, Jan 31, 2023 at 11:32 PM Piotr P. Karwasz wrote: > > Hi Vol

Re: [VOTE] Release Apache Log4j Tools 0.2.0

2023-01-31 Thread Piotr P. Karwasz
Hi Volkan, The signatures are correct and the build is reproducible: +1. On Tue, 31 Jan 2023 at 18:18, Volkan Yazıcı wrote: > * Added XSD for `log4j-changelog` XML files Just a reminder: if the vote passes, the XSD must be published under https://logging.apache.org/log4j/changelog-0.1.0.xsd (sh

[VOTE] Release Apache Log4j Tools 0.2.0

2023-01-31 Thread Volkan Yazıcı
The Apache Log4j Tools 0.2.0 release is now available for voting. This release contains the following changes: * Fixed Windows compatibility * Fixed unreleased directory order in `ChangelogExporter` * Removed security as a change type from `log4j-changelog` * Added XSD for `log4j-changelog` XML f