Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0 (RC2)

2023-09-17 Thread Volkan Yazıcı
Adding my +1. With that, the release passes with 3 binding +1 votes from Piotr, Gary, and me. I will continue the release process. On Fri, Sep 15, 2023 at 10:54 AM Volkan Yazıcı wrote: > > This is a vote to release the Apache Log4j JMX GUI 2.21.0 (RC2). > > Source repository: https://github.com/

Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0 (RC2)

2023-09-15 Thread Gary Gregory
You're right! Apache RAT does run and I missed it, apologies!: -) Gary On Fri, Sep 15, 2023, 10:42 AM Volkan Yazıcı wrote: > Thanks for the elaborate review Gary. > > > sha512 file points to a non-existent folder "tmp" > > Fixed[1] in `logging-parent` reusable CI scripts. > It will be applicabl

Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0 (RC2)

2023-09-15 Thread Volkan Yazıcı
Thanks for the elaborate review Gary. > sha512 file points to a non-existent folder "tmp" Fixed[1] in `logging-parent` reusable CI scripts. It will be applicable from now on. [1] https://github.com/apache/logging-parent/commit/daa46ba9a5a9879fe5989f01cdf81798f9e844a8 > verify goal does not run

Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0 (RC2)

2023-09-15 Thread Gary D. Gregory
- ASC seems OK. - Can't easily mechanically check sha512 but eyeballing it appears OK. - mvn apache-rat:check OK - Built OK 'mvn clean verify' - Running with 'java -jar target\...jar localhost:333' starts the app and fails which is fine since I did not try with an actual app. - We have ... ZERO

Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0 (RC2)

2023-09-15 Thread Gary D. Gregory
Not a blocker but should be fixed IMO: The verify goal does not run apache-rat:check Gary On 2023/09/15 08:54:45 Volkan Yazıcı wrote: > This is a vote to release the Apache Log4j JMX GUI 2.21.0 (RC2). > > Source repository: https://github.com/apache/logging-log4j-jmx-gui > Commit: c3056b340f57e

Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0 (RC2)

2023-09-15 Thread Gary D. Gregory
Probably not a blocker but the sha512 file can't be validated with the usual: $ shasum --check apache-log4j-jmx-gui-2.21.0-src.zip.sha512 Instead I get: shasum: /tmp/apache-log4j-jmx-gui-2.21.0-src.zip: No such file or directory /tmp/apache-log4j-jmx-gui-2.21.0-src.zip: FAILED open or read shasu

Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0 (RC2)

2023-09-15 Thread Piotr P. Karwasz
Hi Volkan, On Fri, 15 Sept 2023 at 10:54, Volkan Yazıcı wrote: > Please download, test, and cast your votes on this mailing list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... I checked the release: * the Maven artifacts are the same as those locally generated, * the bi

Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0

2023-09-15 Thread Gary Gregory
A unit test would help? Gary On Fri, Sep 15, 2023, 4:46 AM Volkan Yazıcı wrote: > Cancelling this vote due to missing `Main-Class` in `MANIFEST.MF`. As > a matter of fact, it has been missing for quite some time in `2.x` > too. Pretty solid indication that nobody is using it. Nevertheless, I >

[VOTE] Release Apache Log4j JMX GUI 2.21.0 (RC2)

2023-09-15 Thread Volkan Yazıcı
This is a vote to release the Apache Log4j JMX GUI 2.21.0 (RC2). Source repository: https://github.com/apache/logging-log4j-jmx-gui Commit: c3056b340f57e2d6bd66b9f825722c336090d0d2 Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j-jmx-gui Nexus: https://repository.apache.org/conte

Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0

2023-09-15 Thread Volkan Yazıcı
Cancelling this vote due to missing `Main-Class` in `MANIFEST.MF`. As a matter of fact, it has been missing for quite some time in `2.x` too. Pretty solid indication that nobody is using it. Nevertheless, I want to bury the project in decency. I will fix the problem, test it, and issue an RC2. On

Re: [VOTE] Release Apache Log4j JMX GUI 2.21.0

2023-09-14 Thread Remko Popma
+1 Remko > On Sep 14, 2023, at 16:34, Volkan Yazıcı wrote: > > This is a vote to release the Apache Log4j JMX GUI 2.21.0. > > Source repository: https://github.com/apache/logging-log4j-jmx-gui > Commit: 35d3021e995393a0f62198c2c65af8b47e42688b > Distribution: https://dist.apache.org/repos/

[VOTE] Release Apache Log4j JMX GUI 2.21.0

2023-09-14 Thread Volkan Yazıcı
This is a vote to release the Apache Log4j JMX GUI 2.21.0. Source repository: https://github.com/apache/logging-log4j-jmx-gui Commit: 35d3021e995393a0f62198c2c65af8b47e42688b Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j-jmx-gui Nexus: https://repository.apache.org/content/rep