Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-12 Thread Piotr P. Karwasz
Hi Gary, On Tue, 13 Sept 2022 at 00:05, Gary Gregory wrote: > > I did get other errors in core but they are intermittent so I only want to > figure out what is the problem with these since they happen every time. The culprit might be the `json-unit` bump I performed: https://github.com/apache/lo

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-12 Thread Gary Gregory
I did get other errors in core but they are intermittent so I only want to figure out what is the problem with these since they happen every time. Gary On Mon, Sep 12, 2022, 13:26 Matt Sicker wrote: > Are you getting any other test failures besides the GelfLayoutTest one? > > On Mon, Sep 12, 20

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-12 Thread Ralph Goers
Wonderful. That really needs to be fixed so this vote will have to be cancelled. Also, can someone fix the test Gary is having a problem with? Ralph > On Sep 12, 2022, at 2:20 PM, Piotr P. Karwasz wrote: > > Hi Ralph, > > On Sat, 10 Sept 2022 at 00:56, Ralph Goers wrote: >> Maven Artifacts

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-12 Thread Piotr P. Karwasz
Hi Ralph, On Sat, 10 Sept 2022 at 00:56, Ralph Goers wrote: > Maven Artifacts: > https://repository.apache.org/content/repositories/orgapachelogging-1088/ I think I left a big bug in log4j-slf4j2-impl/pom.xml: the JUnit artifacts are in the compile scope. Piotr

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-12 Thread Matt Sicker
Are you getting any other test failures besides the GelfLayoutTest one? On Mon, Sep 12, 2022 at 11:24 AM Gary Gregory wrote: > > Check, I am using Java 8 (with a Maven toolchain obviously). > > Gary > > On Mon, Sep 12, 2022, 08:45 Ralph Goers wrote: > > > I believe Matt is referring to the error

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-12 Thread Gary Gregory
Check, I am using Java 8 (with a Maven toolchain obviously). Gary On Mon, Sep 12, 2022, 08:45 Ralph Goers wrote: > I believe Matt is referring to the errors Ron saw when trying to only use > Java 11. > The errors you saw Gary would be an entirely different matter. > > Ralph > > > On Sep 12, 202

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-12 Thread Ralph Goers
I believe Matt is referring to the errors Ron saw when trying to only use Java 11. The errors you saw Gary would be an entirely different matter. Ralph > On Sep 12, 2022, at 8:41 AM, Matt Sicker wrote: > > The sun.reflect test error is due to running Maven using Java 11. > You'll need to run M

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-12 Thread Matt Sicker
The sun.reflect test error is due to running Maven using Java 11. You'll need to run Maven using Java 8 (so that it's used as the default compiler for all the modules that don't override the toolchain to use) with Java 11 as a toolchain entry to compile the Java 9 and Java 11 modules. On Mon, Sep

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-12 Thread Gary Gregory
I'm not sure I understand, but the bottom line is I can't build the release from sources. Surely we can't say that disabling tests to validate or build a release is ok? Gary On Sun, Sep 11, 2022, 16:46 Matt Sicker wrote: > I get the same error when running on java 11, too, but that’s to be > ex

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-11 Thread Matt Sicker
I get the same error when running on java 11, too, but that’s to be expected. I wrote that test originally to explicitly detect the point at which we’d have to do something about it, and we already addressed the original issue long ago. In the 2.x branch, this is handled by using Maven toolchain

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-11 Thread Piotr P. Karwasz
Hi Gary, On Sun, 11 Sept 2022 at 18:13, Gary Gregory wrote: > > java.lang.IllegalStateException: Unexpected message larger than 4096 bytes This is probably due to the 8192 bytes limit in `EncodingListAppender.Destination`. We should probably increase it. Piotr

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-11 Thread Ron Grabowski
I saw the same errors with JDK8 on Windows: openjdk version "1.8.0_342" OpenJDK Runtime Environment Corretto-8.342.07.3 (build 1.8.0_342-b07) OpenJDK 64-Bit Server VM Corretto-8.342.07.3 (build 25.342-b07, mixed mode) [ERROR] Errors: [ERROR] GelfLayoutTest.testLayoutNewLineDelimiter:286->testC

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-11 Thread Matt Sicker
+1 Tested on combination of: openjdk version "1.8.0_322" OpenJDK Runtime Environment (Zulu 8.60.0.21-CA-macos-aarch64) (build 1.8.0_322-b06) OpenJDK 64-Bit Server VM (Zulu 8.60.0.21-CA-macos-aarch64) (build 25.322-b06, mixed mode) openjdk version "11.0.15" 2022-04-19 LTS OpenJDK Runtime Envir

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-11 Thread Matt Sicker
Gary, the `kotlin` directory is for placing release candidates for the Log4j Kotlin API. Same with the `scala` directory there. Whenever I promote a release candidate to a release, I use `svn mv` between dist/dev to dist/prod basically. See step (13) in https://cwiki.apache.org/confluence/displ

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-11 Thread Boris Unckel
+1 Tested against * WildFly Core main with -DallTests ( https://github.com/wildfly/wildfly-core/ ) * JBoss Logging 3.4 branch ( https://github.com/jboss-logging/jboss-logging/tree/3.4 ) * Log4j2 JBoss Logmanager main( https://github.com/jboss-logging/log4j2-jboss-logmanager ) Regards Boris > R

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-10 Thread Gary Gregory
Is the directory https://dist.apache.org/repos/dist/dev/logging/log4j/kotlin/ empty on purpose? Gary On Fri, Sep 9, 2022, 15:56 Ralph Goers wrote: > This is a vote to release Log4j 2.19.0, the next version of the Log4j 2 > project. > > Note that the security page on the web site was updated to

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-10 Thread Piotr P. Karwasz
Hi, On Sat, 10 Sept 2022 at 19:14, Ralph Goers wrote: > That is in RELEASE_NOTES.md and shows up in > https://logging.staged.apache.org/log4j/2.x/changes-report.html#a2.19.0. > I see your commit to the log4j-slf4j index. IMO that isn’t important enough > to respin the release. IMO this is also

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-10 Thread Ralph Goers
> On Sep 9, 2022, at 10:56 PM, Piotr P. Karwasz wrote: > > Hi Ralph, > > On Sat, 10 Sept 2022 at 00:56, Ralph Goers wrote: >> Web Site: https://logging.staged.apache.org/log4j/2.x/index.html. > > I forgot to document the removal of `log4j-slf4j18-impl` and the new > `log4j-slf4j2-impl`: >

Re: [VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-09 Thread Piotr P. Karwasz
Hi Ralph, On Sat, 10 Sept 2022 at 00:56, Ralph Goers wrote: > Web Site: https://logging.staged.apache.org/log4j/2.x/index.html. I forgot to document the removal of `log4j-slf4j18-impl` and the new `log4j-slf4j2-impl`: https://logging.staged.apache.org/log4j/2.x/log4j-slf4j-impl/index.html I pu

[VOTE] Release Apache Log4j 2.19.0-rc1

2022-09-09 Thread Ralph Goers
This is a vote to release Log4j 2.19.0, the next version of the Log4j 2 project. Note that the security page on the web site was updated to better describe CVE-2021-44228 and CVE-2021-45046. Please review those changes. Please download, test, and cast your votes on the log4j developers list. []