[RESULT] [VOTE] Add branch protection rules to Log4j

2025-04-10 Thread Piotr P. Karwasz
Hi, These are my votes: On 2.04.2025 19:12, Piotr P. Karwasz wrote: Vote 1. Require a pull request before merging: [ ] +1, enable this feature [ ] -1, do not enable this feature +1 Vote 2. Require conversation resolution before merging: [ ] +1, enable this feature [ ] -1, do not enable this

Re: [VOTE] Add branch protection rules to Log4j

2025-04-05 Thread Piotr P. Karwasz
Hi all, Sorry, my e-mail client reformatted some lines. So, the concerned repos are all non-dormant Java repos: l-admin, l-jdk, l-jmx-gui, l-log4j2, l-log4j-jakarta, l-log4j-kotlin, l-log4j-samples, l-log4j-scala, l-log4j-transform, l-log4j-tools, l-parent. Vote 1. Require a pull request befor

Re: [VOTE] Add branch protection rules to Log4j

2025-04-04 Thread Ralph Goers
I am finding this email confusing. I think it is due to the formatting but I am not sure. I am making my best guess. Vote 1: Enable certain branch protection features on the code branches (`2.x` and `main`) of all non-dormant Java repos: I can’t vote on this as I don’t know what the impact of t

Re: [VOTE] Add branch protection rules to Log4j

2025-04-04 Thread Jan Friedrich
Hi, Vote 1. Require a pull request before merging: +1 Vote 2. Require conversation resolution before merging: +1 Vote 3. Require linear history (Prevent merge commits from being pushed to code branches. Only "Squash" and similar allowed): -0.9 I really like a linear history, but I see some prob

Re: [VOTE] Add branch protection rules to Log4j

2025-04-04 Thread Volkan Yazıcı
On Wed, Apr 2, 2025 at 7:12 PM Piotr P. Karwasz wrote: > Hi all, > Sorry, my e-mail client reformatted some lines. > So, the concerned repos are all non-dormant Java repos: l-admin, l-jdk, > l-jmx-gui, l-log4j2, l-log4j-jakarta, l-log4j-kotlin, l-log4j-samples, > l-log4j-scala, l-log4j-transform,

Re: [VOTE] Add branch protection rules to Log4j

2025-04-04 Thread Gary Gregory
On Fri, Apr 4, 2025 at 4:07 AM Volkan Yazıcı wrote: > > On Wed, Apr 2, 2025 at 7:12 PM Piotr P. Karwasz > wrote: > > > Hi all, > > Sorry, my e-mail client reformatted some lines. > > So, the concerned repos are all non-dormant Java repos: l-admin, l-jdk, > > l-jmx-gui, l-log4j2, l-log4j-jakarta,

Re: [VOTE] Add branch protection rules to Log4j

2025-04-03 Thread Ralph Goers
OK. With the new descriptions I can vote on this. > On Apr 2, 2025, at 10:12 AM, Piotr P. Karwasz > wrote: > > Hi all, > Sorry, my e-mail client reformatted some lines. > So, the concerned repos are all non-dormant Java repos: l-admin, l-jdk, > l-jmx-gui, l-log4j2, l-log4j-jakarta, l-log4j-kot

[VOTE] Add branch protection rules to Log4j

2025-04-03 Thread Piotr P. Karwasz
Hi all, Trying to implement the RTC rules we discussed in September[1] I encountered some problems due to the limitations of the currently available GitHub Settings. This is a vote to decide whether or not enable certain branch protection features on the code branches (`2.x` and `main`) of th

Re: [VOTE] Add branch protection rules to Log4j

2025-04-02 Thread Piotr P. Karwasz
Hi Ralph, On 2.04.2025 17:40, Ralph Goers wrote: I am finding this email confusing. I think it is due to the > formatting but I am not sure. I am making my best guess. Sorry, the e-mail client ate some new line characters. Vote 1: Enable certain branch protection features on the code > branc