Re: [PROPOSAL] New module log4j-jetty

2017-11-10 Thread Gary Gregory
On Thu, Nov 9, 2017 at 3:33 PM, Gary Gregory wrote: > On Thu, Nov 9, 2017 at 3:32 PM, Ralph Goers > wrote: > >> >> > On Nov 9, 2017, at 2:34 PM, Gary Gregory >> wrote: >> > >> > On Thu, Nov 9, 2017 at 1:49 PM, Ralph Goers > > >> > wrote: >> > >> >> Every module equates to another jar. I just do

Re: [PROPOSAL] New module log4j-jetty

2017-11-09 Thread Gary Gregory
On Thu, Nov 9, 2017 at 3:32 PM, Ralph Goers wrote: > > > On Nov 9, 2017, at 2:34 PM, Gary Gregory wrote: > > > > On Thu, Nov 9, 2017 at 1:49 PM, Ralph Goers > > wrote: > > > >> Every module equates to another jar. I just don’t see why we need a jar > >> for one class where a jar with 2 (as well

Re: [PROPOSAL] New module log4j-jetty

2017-11-09 Thread Ralph Goers
> On Nov 9, 2017, at 2:34 PM, Gary Gregory wrote: > > On Thu, Nov 9, 2017 at 1:49 PM, Ralph Goers > wrote: > >> Every module equates to another jar. I just don’t see why we need a jar >> for one class where a jar with 2 (as well as classes for other app servers) >> will serve equally as well.

Re: [PROPOSAL] New module log4j-jetty

2017-11-09 Thread Gary Gregory
On Thu, Nov 9, 2017 at 1:49 PM, Ralph Goers wrote: > Every module equates to another jar. I just don’t see why we need a jar > for one class where a jar with 2 (as well as classes for other app servers) > will serve equally as well. > First, thank you for being patient here and continuing to ent

Re: [PROPOSAL] New module log4j-jetty

2017-11-09 Thread Mikael Ståldal
On 2017-11-09 20:09, Matt Sicker wrote: On 9 November 2017 at 11:34, Gary Gregory wrote: I do not want to drag Tomcat down into my local repo or on my class path in my IDE just because I am depending on log4j-appserver's one class for Jetty logging. There are certain dependencies in use alr

Re: [PROPOSAL] New module log4j-jetty

2017-11-09 Thread Ralph Goers
Every module equates to another jar. I just don’t see why we need a jar for one class where a jar with 2 (as well as classes for other app servers) will serve equally as well. Ralph > On Nov 9, 2017, at 1:16 PM, Gary Gregory wrote: > > It seems to me that what repo this lives in is an orthogo

Re: [PROPOSAL] New module log4j-jetty

2017-11-09 Thread Gary Gregory
It seems to me that what repo this lives in is an orthogonal concern. We already have plenty of repos IMO, I don't want to track another one, but hey, that's just me. If log4j-appserver is OK in the main repo, so should log4j-jetty. Gary On Thu, Nov 9, 2017 at 1:07 PM, Ralph Goers wrote: > If y

Re: [PROPOSAL] New module log4j-jetty

2017-11-09 Thread Ralph Goers
If you want a specific log4-jetty than we should create a log4j-appserver repo and make log4j-tomcat and log4j-jetty there. Otherwise just put it in log4j-appserver with a provided dependency. Ralph > On Nov 9, 2017, at 11:54 AM, Gary Gregory wrote: > > How about we rename log4j-appserver to

Re: [PROPOSAL] New module log4j-jetty

2017-11-09 Thread Gary Gregory
On Thu, Nov 9, 2017 at 12:09 PM, Matt Sicker wrote: > On 9 November 2017 at 11:34, Gary Gregory wrote: > > > I do not want to drag > > Tomcat down into my local repo or on my class path in my IDE just > because I > > am depending on log4j-appserver's one class for Jetty logging. > > > > There ar

Re: [PROPOSAL] New module log4j-jetty

2017-11-09 Thread Matt Sicker
On 9 November 2017 at 11:34, Gary Gregory wrote: > I do not want to drag > Tomcat down into my local repo or on my class path in my IDE just because I > am depending on log4j-appserver's one class for Jetty logging. > There are certain dependencies in use already that bring in half the internet

Re: [PROPOSAL] New module log4j-jetty

2017-11-09 Thread Gary Gregory
How about we rename log4j-appserver to log4j-tomcat and add log4j-jetty? Gary On Thu, Nov 9, 2017 at 10:45 AM, Ralph Goers wrote: > Oops. It should be marked as provided. Almost the same effect though. > > Ralph > > > On Nov 9, 2017, at 10:44 AM, Ralph Goers > wrote: > > > > The dependency on

Re: [PROPOSAL] New module log4j-jetty

2017-11-09 Thread Ralph Goers
Oops. It should be marked as provided. Almost the same effect though. Ralph > On Nov 9, 2017, at 10:44 AM, Ralph Goers wrote: > > The dependency on Tomcat should have been marked optional. That is my mistake. > > Ralph > >> On Nov 9, 2017, at 10:34 AM, Gary Gregory wrote: >> >> What about o

Re: [PROPOSAL] New module log4j-jetty

2017-11-09 Thread Ralph Goers
The dependency on Tomcat should have been marked optional. That is my mistake. Ralph > On Nov 9, 2017, at 10:34 AM, Gary Gregory wrote: > > What about our theme/epic of reducing dependencies? I do not want to drag > Tomcat down into my local repo or on my class path in my IDE just because I > a

Re: [PROPOSAL] New module log4j-jetty

2017-11-09 Thread Gary Gregory
What about our theme/epic of reducing dependencies? I do not want to drag Tomcat down into my local repo or on my class path in my IDE just because I am depending on log4j-appserver's one class for Jetty logging. Gary On Thu, Nov 9, 2017 at 9:22 AM, Ralph Goers wrote: > That is exactly what log

Re: [PROPOSAL] New module log4j-jetty

2017-11-09 Thread Ralph Goers
That is exactly what log4j-appserver is for. Right now it contains the hook for Tomcat 8.5. Having that class in a jar that also contains the hook for Jetty shouldn’t cause any problems. Ralph > On Nov 9, 2017, at 8:55 AM, Gary Gregory wrote: > > I would like to propose we add a new module ca

[PROPOSAL] New module log4j-jetty

2017-11-09 Thread Gary Gregory
I would like to propose we add a new module called log4j-jetty whose sole purpose is to implement org.eclipse.jetty.util.log.Logger There is a way to get Log4j 1 and 2 to work with Jetty but it has to go through Slf4j. I'd rather go directly. Thoughts? Gary