Re: [Log4j] Lucene 5 Appender

2017-07-16 Thread Ralph Goers
It is fine as long as it is documented that it can and why. Ralph > On Jul 16, 2017, at 11:22 PM, Gary Gregory wrote: > > On Sun, Jul 16, 2017 at 11:20 PM, Ralph Goers > wrote: > >> If there is no split then events could be lost during a reconfigure. >> > > Yes, I know. I am wondering if we

Re: [Log4j] Lucene 5 Appender

2017-07-16 Thread Ralph Goers
I should add that it isn’t very likely though. Ralph > On Jul 16, 2017, at 11:20 PM, Ralph Goers wrote: > > If there is no split then events could be lost during a reconfigure. > > Ralph > >> On Jul 16, 2017, at 11:18 PM, Gary Gregory wrote: >> >> Hi All: >> >> I have a Lucene5 branch base

Re: [Log4j] Lucene 5 Appender

2017-07-16 Thread Gary Gregory
On Sun, Jul 16, 2017 at 11:20 PM, Ralph Goers wrote: > If there is no split then events could be lost during a reconfigure. > Yes, I know. I am wondering if we should allow for this issue in this new module and let users provide patches. Gary > > Ralph > > > On Jul 16, 2017, at 11:18 PM, Gary

Re: [Log4j] Lucene 5 Appender

2017-07-16 Thread Ralph Goers
If there is no split then events could be lost during a reconfigure. Ralph > On Jul 16, 2017, at 11:18 PM, Gary Gregory wrote: > > Hi All: > > I have a Lucene5 branch based on a patch from a user which said user has in > production. > > The only obvious failing I see is that there is no split

[Log4j] Lucene 5 Appender

2017-07-16 Thread Gary Gregory
Hi All: I have a Lucene5 branch based on a patch from a user which said user has in production. The only obvious failing I see is that there is no split between appender and manager. The manager split could be done later. I am wondering if anyone has time to code review the branch. Thank you, G