Github user chlowell closed the pull request at:
https://github.com/apache/logging-log4net/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user chlowell commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r134377119
--- Diff: tests/src/log4net.Tests.csproj ---
@@ -19,245 +18,25 @@
under the License.
-->
-http://schemas.microsoft.com/developer
Github user chlowell commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r134355177
--- Diff: tests/src/Context/LogicalThreadContextTest.cs ---
@@ -17,7 +17,7 @@
//
#endregion
-#if NET_4_5 || NETSTANDARD1_3
+#
Github user chlowell commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r134354215
--- Diff: src/CompatibilityExtensions.cs ---
@@ -0,0 +1,53 @@
+#region Apache License
+//
+// Licensed to the Apache Software Foundati
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133930064
--- Diff: tests/src/log4net.Tests.csproj ---
@@ -19,245 +18,25 @@
under the License.
-->
-http://schemas.microsoft.com/developer
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133929485
--- Diff: tests/src/Context/LogicalThreadContextTest.cs ---
@@ -17,7 +17,7 @@
//
#endregion
-#if NET_4_5 || NETSTANDARD1_3
+#
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133929178
--- Diff: src/CompatibilityExtensions.cs ---
@@ -0,0 +1,53 @@
+#region Apache License
+//
+// Licensed to the Apache Software Foundati
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133928541
--- Diff: Jenkinsfile ---
@@ -61,21 +61,14 @@ pipeline {
// run docker container
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133928219
--- Diff: src/Appender/AppenderSkeleton.cs ---
@@ -321,7 +321,7 @@ public void DoAppend(LoggingEvent loggingEvent)
{
Github user chlowell commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133848915
--- Diff: tests/src/log4net.Tests.csproj ---
@@ -19,245 +18,25 @@
under the License.
-->
-http://schemas.microsoft.com/developer
Github user chlowell commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133846257
--- Diff: src/Appender/AppenderSkeleton.cs ---
@@ -321,7 +321,7 @@ public void DoAppend(LoggingEvent loggingEvent)
{
Github user chlowell commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133846136
--- Diff: src/CompatibilityExtensions.cs ---
@@ -0,0 +1,53 @@
+#region Apache License
+//
+// Licensed to the Apache Software Foundati
Github user chlowell commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133845941
--- Diff: tests/src/Context/LogicalThreadContextTest.cs ---
@@ -17,7 +17,7 @@
//
#endregion
-#if NET_4_5 || NETSTANDARD1_3
+#
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133704161
--- Diff: tests/src/log4net.Tests.csproj ---
@@ -19,245 +18,25 @@
under the License.
-->
-http://schemas.microsoft.com/developer
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133700988
--- Diff: Jenkinsfile ---
@@ -61,21 +61,14 @@ pipeline {
// run docker container
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133703322
--- Diff: src/Util/PatternStringConverters/UserNamePatternConverter.cs ---
@@ -69,6 +69,12 @@ override protected void Convert(TextWriter writer,
obj
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133703847
--- Diff: tests/src/Context/LogicalThreadContextTest.cs ---
@@ -17,7 +17,7 @@
//
#endregion
-#if NET_4_5 || NETSTANDARD1_3
+#
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133703032
--- Diff: src/CompatibilityExtensions.cs ---
@@ -0,0 +1,53 @@
+#region Apache License
+//
+// Licensed to the Apache Software Foundati
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133701487
--- Diff: log4net.build ---
@@ -1748,48 +1748,64 @@ limitations under the License.
-
-
+
+
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133702415
--- Diff: src/Appender/AppenderSkeleton.cs ---
@@ -321,7 +321,7 @@ public void DoAppend(LoggingEvent loggingEvent)
{
GitHub user chlowell opened a pull request:
https://github.com/apache/logging-log4net/pull/14
Add .NET Standard 2.0 build
This adds a netstandard2.0 build consumable on .NET Core 2.0, .NET
Framework 4.6.1+, Xamarin platforms, and the next version of UWP ([this
doc](https://docs.mic
21 matches
Mail list logo
