Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/78
I've been pretty busy lately and haven't gotten to do anything on this
project in a little while. However, as mentioned, this PR can be merged by
anyone else. We don't have plans to release anytim
Github user bsokolovu commented on the issue:
https://github.com/apache/logging-log4j2/pull/78
Hi gatekeepers!
Are you going to merge it and use it? Or you have new comments? Or you just
forgot about it? ))
---
If your project is set up for it, you can reply to this email and ha
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/78
PR looks great! Ready to merge. Thanks for the clarifications regarding
serialization.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user bsokolovu commented on the issue:
https://github.com/apache/logging-log4j2/pull/78
I've amended commit with unit test.
And once more about serialVersionUID - it's not a new version of entity.
It's fix for serialization of an old version. If you revert my fix but keep th
Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/78
The serialVersionUID can remain unchanged if
* the new version of the software can deserialize "old" serialized objects
(backwards compatible)
* the "old" version of the software can des
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/78
Do you have java 9 installed? Make sure to follow the [setup
instructions](https://github.com/apache/logging-log4j2/blob/master/BUILDING.md).
As for the travis check, the thing below the comments.
Github user bsokolovu commented on the issue:
https://github.com/apache/logging-log4j2/pull/78
I don't see reasons to change serialVersionUID. It's not new version of
entity.
I'd like to add unit test but I can't build even `master` branch because of
some odd error on execution `j
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/78
Code looks good. Can you add a unit test? Also, does the serialVersionUID
need to be changed, or is this a safe serialization change?
---
If your project is set up for it, you can reply to this e