[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

Github user jasontedor commented on the issue: https://github.com/apache/logging-log4j2/pull/109 I can confirm that as well, both the unit tests we have that rely on this are passing now, and the application is logging the correct location when `%l` is used as a pattern. ---

[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

Github user rgoers commented on the issue: https://github.com/apache/logging-log4j2/pull/109 I just tried running one of my webapps on tomcat under Java 9. Although I didn't have much success due to Spring (that is a different story) I do see the location information correctly. ---

[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

Github user MartyIX commented on the issue: https://github.com/apache/logging-log4j2/pull/109 @jasontedor Does Log4j2 2.9.1 (with JDK 9) work correctly for you? All my log messages contain `calcLocation` method name. Am I the only one? When I switch to JDK 8, it works as expec

[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

Github user jasontedor commented on the issue: https://github.com/apache/logging-log4j2/pull/109 Thanks @rgoers. ---

[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

Github user jasontedor commented on the issue: https://github.com/apache/logging-log4j2/pull/109 @MartyIX The bug report is linked [above](https://github.com/apache/logging-log4j2/pull/109#issuecomment-326626895). The bug manifests as that the source line on any logging event will app

[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

Github user MartyIX commented on the issue: https://github.com/apache/logging-log4j2/pull/109 @jasontedor > This is due to a bug in the JDK 9 implementation of StackLocator. Do you happen to have a bug report link? Thank you :) --- If your project is set up

[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

Github user jasontedor commented on the issue: https://github.com/apache/logging-log4j2/pull/109 You're welcome @rgoers, it is my pleasure. I pushed a commit as we discussed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

Github user rgoers commented on the issue: https://github.com/apache/logging-log4j2/pull/109 @jasontedor Thanks for contributing to Log4j - we appreciate all the help we can get! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

Github user jasontedor commented on the issue: https://github.com/apache/logging-log4j2/pull/109 @rgoers Thanks for the feedback, that makes sense! I will do this: - make a change that will make that work - add a comment to the code that explains why the code is doing what it'

[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

Github user rgoers commented on the issue: https://github.com/apache/logging-log4j2/pull/109 Finding the frame prior to the first frame that matches the class name of the logger is likely to return a frame that still points at the logger class because multiple methods in the logger ma

[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

Github user jasontedor commented on the issue: https://github.com/apache/logging-log4j2/pull/109 This is for: https://issues.apache.org/jira/browse/LOG4J2-2028 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje