Even better! Thanks.
On Sat, Jun 29, 2019 at 11:47, Ralph Goers
wrote:
> Umm. The release went live last night so there can’t be more release
> candidates.
>
> Ralph
>
> > On Jun 29, 2019, at 9:31 AM, Matt Sicker wrote:
> >
> > I can update it, yes, but I don’t think it’s warrant for another re
Umm. The release went live last night so there can’t be more release candidates.
Ralph
> On Jun 29, 2019, at 9:31 AM, Matt Sicker wrote:
>
> I can update it, yes, but I don’t think it’s warrant for another release
> candidate.
>
> On Sat, Jun 29, 2019 at 10:31, Gary Gregory wrote:
>
>> On Fr
I can update it, yes, but I don’t think it’s warrant for another release
candidate.
On Sat, Jun 29, 2019 at 10:31, Gary Gregory wrote:
> On Fri, Jun 28, 2019 at 11:32 AM Matt Sicker wrote:
>
> > Ok, I see that it's already tested right there. Then it really is safe
> > to add an assumeThat() to
On Fri, Jun 28, 2019 at 11:32 AM Matt Sicker wrote:
> Ok, I see that it's already tested right there. Then it really is safe
> to add an assumeThat() to the test that uses reflection to access the
> deprecated API. That test can be safely ignored once the deprecated
> API is removed since we alre
Ok, I see that it's already tested right there. Then it really is safe
to add an assumeThat() to the test that uses reflection to access the
deprecated API. That test can be safely ignored once the deprecated
API is removed since we already test compatibility with the
replacement API.
On Fri, 28 J
StackLocatorTest in log4j-api-java9 has some tests to validate the Java 9
StackLocator is working. You could add code that uses StackWalker right now if
you want.
Ralph
> On Jun 28, 2019, at 6:37 AM, Matt Sicker wrote:
>
> Thanks for clarifying that. The failing test is one that I wrote long
Thanks for clarifying that. The failing test is one that I wrote long ago
back when I thought they’d never remove the internal class, and the point
of the test is to ensure the behavior of the caller class algorithm matches
the internal API behavior. Realistically, a Java 9+ version of that test
wo
What is missing is the patch to the test that Matt provided. I tried applying
his changes manually and the test still failed for me. The problem is the test
is trying to use a class that doesn’t exist in Java 11. The “fix” is to have
unit automatically ignore those tests when the classes don’t e
On Fri, Jun 28, 2019 at 8:25 AM Gary Gregory wrote:
> Ah! You can force compilation to be skipped with '-Dmaven.main.skip' so
> you can 'compile' and 'install' jars with Java 8 and then run 'mvn test
> -Dmaven.main.skip' with Java 11 which gives me:
>
> [INFO] Running org.apache.logging.log4j.uti
Ah! You can force compilation to be skipped with '-Dmaven.main.skip' so you
can 'compile' and 'install' jars with Java 8 and then run 'mvn test
-Dmaven.main.skip' with Java 11 which gives me:
[INFO] Running org.apache.logging.log4j.util.StackLocatorUtilTest
WARNING: sun.reflect.Reflection.getCalle
The java setup has me blocked currently for developing more complicated
code where I want to use inline test execution in my IDE. It’s not a
blocker for building, though.
On Thu, Jun 27, 2019 at 19:51, Gary Gregory wrote:
> On Thu, Jun 27, 2019 at 8:06 PM Ralph Goers
> wrote:
>
> > So does this
On Thu, Jun 27, 2019 at 8:06 PM Ralph Goers
wrote:
> So does this mean you won’t be voting on this release even though it
> behaves the same as the previous releases?
>
I am struggling with it. I am still looking for a way to test with Java
11... it feels pretty bad that we cannot say anything a
I’ll be voting. I just haven’t had a chance to test it out yet (busy week).
On Thu, Jun 27, 2019 at 19:06, Ralph Goers
wrote:
> So does this mean you won’t be voting on this release even though it
> behaves the same as the previous releases?
>
> Ralph
>
> > On Jun 27, 2019, at 11:08 AM, Gary Gre
So does this mean you won’t be voting on this release even though it behaves
the same as the previous releases?
Ralph
> On Jun 27, 2019, at 11:08 AM, Gary Gregory wrote:
>
> On Thu, Jun 27, 2019 at 2:06 PM Ralph Goers
> wrote:
>
>> What was the last release where you could build and test wit
Try the full commit:
https://github.com/apache/logging-log4j2/commit/acbd23054492ba71878a4aeebf03c92a0bcf7aa1
On Thu, 27 Jun 2019 at 12:18, Ralph Goers wrote:
>
> The vote is a little over half-way through and so far only Remko has voted. I
> haven’t seen anything yet that would make me vote aga
On Thu, Jun 27, 2019 at 2:06 PM Ralph Goers
wrote:
> What was the last release where you could build and test with Java 11?
> AFAIK this problem is not new to this release.
>
No idea, sorry.
Gary
>
> Ralph
>
> > On Jun 27, 2019, at 10:54 AM, Gary Gregory
> wrote:
> >
> > Running the build on
On Thu, Jun 27, 2019 at 1:54 PM Gary Gregory wrote:
> Running the build on Java 8 was fine for me. I am concerned that it is not
> testable on Java 11 in the usual Maven way. I cannot find a way to run the
> tests without Maven deciding it needs to recompile everything.
>
I tried "touch"-ing all
What was the last release where you could build and test with Java 11? AFAIK
this problem is not new to this release.
Ralph
> On Jun 27, 2019, at 10:54 AM, Gary Gregory wrote:
>
> Running the build on Java 8 was fine for me. I am concerned that it is not
> testable on Java 11 in the usual Mave
Running the build on Java 8 was fine for me. I am concerned that it is not
testable on Java 11 in the usual Maven way. I cannot find a way to run the
tests without Maven deciding it needs to recompile everything.
Gary
On Thu, Jun 27, 2019 at 1:18 PM Ralph Goers
wrote:
> The vote is a little ove
The vote is a little over half-way through and so far only Remko has voted. I
haven’t seen anything yet that would make me vote against the release so we
still need one more vote before tomorrow night. All the issues found so far are
very minor.
Matt, as I said I tried applying the changes you
20 matches
Mail list logo
