Re: (logging-parent) branch main updated: Modify review kit

2024-09-03 Thread Ralph Goers
? Clean takes a no time. It ensures no junk is lying around. Ralph > On Sep 3, 2024, at 10:58 AM, Volkan Yazıcı wrote: > > I will remove `clean`, since there is nothing to clean. > We shouldn't add unnecessary overhead. > > On Tue, Sep 3, 2024 at 7:01 PM Piotr P. Karwasz > wrote: > >> Hi Gar

Re: (logging-parent) branch main updated: Modify review kit

2024-09-03 Thread Volkan Yazıcı
I will remove `clean`, since there is nothing to clean. We shouldn't add unnecessary overhead. On Tue, Sep 3, 2024 at 7:01 PM Piotr P. Karwasz wrote: > Hi Gary, > > On Tue, 3 Sept 2024 at 18:25, Gary Gregory wrote: > > > > Why doesn't the maven build in the review kit (below) invoke clean goal?

Re: (logging-parent) branch main updated: Modify review kit

2024-09-03 Thread Piotr P. Karwasz
Hi Gary, On Tue, 3 Sept 2024 at 18:25, Gary Gregory wrote: > > Why doesn't the maven build in the review kit (below) invoke clean goal? > > > +sh mvnw -Prelease clean verify artifact:compare > > -Dreference.repo=$NEXUS_REPO > > + > > +# Run tests only (Windows) > > +sh mvnw -Prelease clean verify

Re: (logging-parent) branch main updated: Modify review kit

2024-09-03 Thread Gary Gregory
Why doesn't the maven build in the review kit (below) invoke clean goal? Gary On Tue, Sep 3, 2024, 11:37 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > pkarwasz pushed a commit to branch main > in repository https://gitbox.apache.org/repos/asf/logging-parent