[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-18 Thread xnslong
Github user xnslong commented on the issue: https://github.com/apache/logging-log4j2/pull/92 I runned this test, but it didn't fail on my machine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-17 Thread xnslong
Github user xnslong commented on the issue: https://github.com/apache/logging-log4j2/pull/92 I followed the tips to run command `mvn -U clean test -pl log4j-core -Dtest=AbstractStringLayoutTest`, and then I checked my local maven repository, but I'm afraid it didn't

[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-17 Thread xnslong
Github user xnslong commented on the issue: https://github.com/apache/logging-log4j2/pull/92 After this failure, could you please check your local maven repository for the log4j-api-2.9-SNAPSHOT version, decompile the jar and check the StringBuilders class. After I got the failure, I

[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-17 Thread xnslong
Github user xnslong commented on the issue: https://github.com/apache/logging-log4j2/pull/92 I reappeared the failure! when I run the tests with `mvn clean test -pl log4j2-core`, I got the following failure (it is just the failure you provided) ``` [ERROR] Failures

[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-17 Thread xnslong
Github user xnslong commented on the issue: https://github.com/apache/logging-log4j2/pull/92 I merged the latest master to my branch just now, Would you please run the case again, and show me the result? @garydgregory --- If your project is set up for it, you can reply to this

[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-17 Thread xnslong
Github user xnslong commented on the issue: https://github.com/apache/logging-log4j2/pull/92 Still reports this problem? Hmm... interesting. I also have ran this case in my IDE, nothing went wrong. Would you please show me the git repository version, maybe we have to check if we are

[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-16 Thread xnslong
Github user xnslong commented on the issue: https://github.com/apache/logging-log4j2/pull/92 Well, the case runs well on my computer. But I notice that the `MAX_STRING_BUILDER_SIZE` is not a constant, instead it may be loaded from the sysstem properties. So I changed my test case, to

[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-12 Thread xnslong
Github user xnslong commented on the issue: https://github.com/apache/logging-log4j2/pull/92 @garydgregory Yes, I noticed that and fixed it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] logging-log4j2 pull request #92: consider the StringBuilder's capacity inste...

2017-07-11 Thread xnslong
GitHub user xnslong opened a pull request: https://github.com/apache/logging-log4j2/pull/92 consider the StringBuilder's capacity instead of content length when do the trim The trim operation aims at releasing the too much memory occupied by the `StringBuilder`. So whe