Github user taylorp36 closed the pull request at:
https://github.com/apache/logging-log4j2/pull/108
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user taylorp36 commented on the issue:
https://github.com/apache/logging-log4j2/pull/108
Sure, I like the builder idea. I was hesitant to modify TcpSocketManager
initially. Sounds like Gary might already have a fix though.
---
If your project is set up for it, you can reply
Github user taylorp36 commented on the issue:
https://github.com/apache/logging-log4j2/pull/108
Yeap, the trouble I had extending TcpSocketManager was that Reconnector and
Socket were both being mutated in the write() and reconnect(). Without having
setters on those fields in
Github user taylorp36 commented on the issue:
https://github.com/apache/logging-log4j2/pull/108
The code path is very similar; the tests in
**org.apache.logging.log4j.core.appender.net** call the appender directly, and
the test in **org.apache.logging.log4j.core.appender** applies
Github user taylorp36 commented on the issue:
https://github.com/apache/logging-log4j2/pull/108
I added a test in the SocketAppenderTest, are there any more tests we need
for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user taylorp36 opened a pull request:
https://github.com/apache/logging-log4j2/pull/108
LOG4J2-2013 Handle reconnect in SSLSocketManager without losing SSLCoâ¦
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/taylorp36
