[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

2017-09-22 Thread rgoers
Github user rgoers commented on the issue: https://github.com/apache/logging-log4j2/pull/109 I just tried running one of my webapps on tomcat under Java 9. Although I didn't have much success due to Spring (that is a different story) I do see the location information correctly. ---

[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

2017-09-01 Thread rgoers
Github user rgoers commented on the issue: https://github.com/apache/logging-log4j2/pull/109 @jasontedor Thanks for contributing to Log4j - we appreciate all the help we can get! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

2017-09-01 Thread rgoers
Github user rgoers commented on the issue: https://github.com/apache/logging-log4j2/pull/109 Finding the frame prior to the first frame that matches the class name of the logger is likely to return a frame that still points at the logger class because multiple methods in the logger

[GitHub] logging-log4j2 issue #29: Property log4j.skipJansi should have a default of ...

2017-08-16 Thread rgoers
Github user rgoers commented on the issue: https://github.com/apache/logging-log4j2/pull/29 @mikaelstaldal We have to change the default value as it can cause application startup to fail. @garydgregory I don't think it is a great loss for the status logger not to suppo

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797743 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/LevelTest.java --- @@ -16,6 +16,12 @@ */ package

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131798431 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/ShutdownTimeoutConfigurationTest.java --- @@ -16,13 +16,14 @@ */ package

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797459 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/HostNameTest.java --- @@ -16,21 +16,24 @@ */ package

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131798543 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/XmlEvents.java --- @@ -23,6 +23,7 @@ import

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797863 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventFactoryTest.java --- @@ -52,7 +53,7 @@ private ListAppender

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131798408 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/PropertiesFileConfigTest.java --- @@ -52,7 +53,7 @@ public void testReconfiguration

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131798474 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/TimestampMessageTest.java --- @@ -16,6 +16,9 @@ */ package

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797094 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/DeadlockTest.java --- @@ -17,6 +17,7 @@ package org.apache.logging.log4j.core

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131798273 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/LoggerUpdateTest.java --- @@ -16,11 +16,15 @@ */ package

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797604 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/CollectionLoggingTest.java --- @@ -26,6 +26,7 @@ import

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797698 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/LateConfigTest.java --- @@ -26,6 +26,7 @@ import

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797908 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventTest.java --- @@ -27,6 +27,7 @@ import

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797263 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/ExtendedLevelTest.java --- @@ -22,6 +22,7 @@ import

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131798421 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/ShutdownDisabledTest.java --- @@ -16,13 +16,14 @@ */ package

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131798101 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/LoggerDateTest.java --- @@ -16,6 +16,8 @@ */ package

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131798369 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/PropertiesFileConfigTest.java --- @@ -24,6 +24,7 @@ import

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797278 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/GcFreeAsynchronousLoggingTest.java --- @@ -18,6 +18,7 @@ import

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797686 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/HostNameTest.java --- @@ -16,21 +16,24 @@ */ package

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r13179 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventFactoryTest.java --- @@ -34,6 +34,7 @@ import

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797060 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/CustomLevelsOverrideTest.java --- @@ -83,9 +83,9 @@ public void testLog

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797963 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventTest.java --- @@ -99,20 +100,20 @@ public void testNanoTimeIsNotSerialized1

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131798450 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/StrictXmlConfigTest.java --- @@ -16,6 +16,8 @@ */ package

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797360 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/GcFreeSynchronousLoggingTest.java --- @@ -32,6 +32,7 @@ public void

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131798324 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/PatternSelectorTest.java --- @@ -16,6 +16,10 @@ */ package

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797217 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/CustomLevelsTest.java --- @@ -26,6 +26,7 @@ import

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131798314 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/LookupTest.java --- @@ -16,14 +16,15 @@ */ package

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797196 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/CustomLevelsWithFiltersTest.java --- @@ -25,6 +25,7 @@ import

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797043 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/CustomLevelsOverrideTest.java --- @@ -83,9 +83,9 @@ public void testLog

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797894 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventFactoryTest.java --- @@ -87,7 +88,7 @@ public void before

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131796906 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/BasicLoggingTest.java --- @@ -28,7 +29,7 @@ @Test public void

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131796799 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/AppenderRefLevelJsonTest.java --- @@ -16,19 +16,20 @@ */ package

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131796844 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/AppenderRefLevelTest.java --- @@ -16,6 +16,8 @@ */ package

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread rgoers
Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797005 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/CronRolloverApp.java --- @@ -20,7 +20,7 @@ import

[GitHub] logging-log4j2 issue #29: Property log4j.skipJansi should have a default of ...

2017-08-07 Thread rgoers
Github user rgoers commented on the issue: https://github.com/apache/logging-log4j2/pull/29 Jansi requires native code? That sucks. That means that Jansi can only be loaded by a single class loader and has to be in Tomcat's classpath. Given that, Jansi should default to

[GitHub] logging-log4j2 issue #91: failing test - irregular log4j2.json nodes order

2017-07-05 Thread rgoers
Github user rgoers commented on the issue: https://github.com/apache/logging-log4j2/pull/91 After a bunch of interesting reading it appears that ES2015 says that Object property names are to be ordered in the following way: integer-like Strings in ascending order, non-integer-like