Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/108
Maybe there should be a TcpSocketManagerBuilder? It could be initialized
from scratch by calling its setter methods, or initialized from a
TcpSocketManager instance so you'd only need to
Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/87
@leventov We may have a Log4j 2.9 release starting as soon as this weekend.
Let me know if you want to make the remaining changes to complete this PR for
merging into master before that
Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/87
Following new developments with interest.
Looking forward to javadoc on the WriteTouch stuff. I just very briefly
scanned the commit on my phone while commuting to work, but didn'
Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/87
@leventov The log4j community is discussing releasing a 2.9 version soon
(in July). I would like to merge your contribution but have you had a chance to
look at the [ICLA](http
Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/87
I don't have access to hardware with that version of Java. I am fairly sure
that 131 doesn't have performance improvements (we checked whether we should
upgrade but it was too close
Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/87
As promised, here are the throughput results on enterprise hardware.
Hardware: total 64 cores (4x 16-core) Intel(R) Xeon(R) CPU E5-2697A v4 @
2.60GHz
Java Hotspot 64-bit server
Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/87
P.S. Roman, are you okay with submitting an
[ICLA](http://www.apache.org/licenses/#clas)? I am still reviewing the patch
but we need the ICLA before it can be merged. If you put "A
Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/87
Roman, thanks for the feedback and the benchmarks.
* Understood about keeping the new package-private classes in the same
package as MemoryMappedFilemanager. No problem
Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/87
Roman, one more thing: since this is a non-trivial patch, would you mind
submitting an [ICLA](http://www.apache.org/licenses/#clas)?
---
If your project is set up for it, you can reply to
Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/87
Roman, I started to review your patch. Initial feedback below (still
reading):
* MemoryMappedFileManager::switchRegion should not throw Error: generally a
logging problem should not
Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/71
I got distracted by other things but still reviewing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/78
The serialVersionUID can remain unchanged if
* the new version of the software can deserialize "old" serialized objects
(backwards compatible)
* the "old" version
Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/71
Do all tests pass when you run `mvn clean install` on your machine? (may
take ~20 minutes)
On Wednesday, May 10, 2017 12:34 AM, Roman Leventov
wrote:
@remkop
Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/71
@leventov Thanks for the quick turnaround. Today I only had time to check
that the tests pass, but I ran `mvn clean install` twice and both times it
failed here:
```
[ERROR] Tests
Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/71
I'm not done reviewing yet but I found two issues:
* StringBuilderEncoder used to have ThreadLocal,
ThreadLocal and ThreadLocal fields, now has one
ThreadLocal field. In the ori
Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/71
Apologies for the delay. I now have some time to start looking at this
again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/71
I'm not so much concerned that users implemented ByteBufferDestination, but
I'm more concerned that subclasses of OutputStreamManager and FileManager still
work. For exampl
Github user remkop commented on the issue:
https://github.com/apache/logging-log4j2/pull/71
@leventov Quick update: Started to look at the PR but did not get far yet.
I'm taking my time because this is a fairly sensitive area. When converting the
OutputStreamAppende
18 matches
Mail list logo
