Github user mikaelstaldal commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/117#discussion_r144729853
--- Diff:
log4j-core/src/test/java/org/apache/logging/log4j/core/appender/mom/kafka/KafkaAppenderTest.java
---
@@ -22,8 +22,8 @@
import
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/112
:+1:
---
Github user mikaelstaldal commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/112#discussion_r142994778
--- Diff:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/mom/kafka/KafkaManager.java
---
@@ -47,18 +47,24
Github user mikaelstaldal commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/112#discussion_r142996203
--- Diff: src/site/xdoc/manual/appenders.xml ---
@@ -1735,6 +1735,11 @@ public class JpaLogEntity extends
AbstractLogEventWrapperEntity
Github user mikaelstaldal commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/112#discussion_r142995363
--- Diff:
log4j-core/src/test/java/org/apache/logging/log4j/core/appender/mom/kafka/KafkaAppenderTest.java
---
@@ -135,6 +135,22 @@ public
Github user mikaelstaldal commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/112#discussion_r142995940
--- Diff: src/site/xdoc/manual/appenders.xml ---
@@ -1735,6 +1735,11 @@ public class JpaLogEntity extends
AbstractLogEventWrapperEntity
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/112
And don't forget to update documentation in `appenders.xml`.
---
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/112
It would also be useful to enable interpolation with
[lookups](https://logging.apache.org/log4j/2.x/manual/lookups.html) for the
key, so that you could e.g. use some value from the
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/112
@flowcont I think it would make more sense to have the value for the key as
an attribute on the Kafka appender element, and not as a nested property, since
the nested properties are
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/110
2.9.1 is now released, and the next release will (most likely) be 2.10.0
which will include this. We have no date set for that release, but historically
there has been at least three
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/110
@mdvorak The code looks fine to me. But we will wait a while before
merging, since we plan to do a 2.9.1 bugfix release soon. This will go into
2.10.0.
---
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/110
@mdvorak I think that we should not care so much about garbage and micro
optimizations in the Jackson based layouts, since they are far from
garbage-free or optimal anyway
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/110
@mdvorak Resolving `${}` expressions during serialization is necessary to
support dynamic lookups which depend on the current log event, such as
[ContextMapLookup](https
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/110
Have a look at the unfinished branch
https://github.com/apache/logging-log4j2/tree/LOG4J2-1694 you can probably pick
suitable unit tests from there.
---
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/110
It would be nice to add this to XmlLayout and YamlLayout also.
---
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/110
Linking to JIRA issue: https://issues.apache.org/jira/browse/LOG4J2-1694
---
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/29
If should add a parameter to ConsoleAppender, I think it should be named
"enableJansi" (or similar) and have default false.
---
If your project is set up for it, you can rep
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/29
@garydgregory OK, maybe keep it as system property then.
BTW, is there a way to safely try to load it on Windows, and gracefully do
without it if the native library is missing
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/29
It would quite strange to have a property with name "skipXXX" with default
value true. And it would also not be a very good idea to change default value
of an existin
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/104
Such warning is bogus, try to disable it rather than adding an unnecessary
method to the code base.
---
If your project is set up for it, you can reply to this email and have your
Github user mikaelstaldal commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/104#discussion_r130701671
--- Diff:
log4j-core/src/test/java/org/apache/logging/log4j/core/appender/HangingAppender.java
---
@@ -90,4 +90,8 @@ public boolean stop
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/29
@jcetkov Can you give more details on how it "dies horribly"? What does the
configuration look like?
---
If your project is set up for it, you can reply to this email and
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/62
@jvz I have no experience with our MongoDB appender, and only limited
experience with MongoDB in general. Maybe better that you, or someone else with
more experience, merge this
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/45
Thanks @prabh27 , applying your patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/46
Can this PR be closed @garydgregory ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/62
Ping @jvz
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/25
Linking: https://issues.apache.org/jira/browse/LOG4J2-1301
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/40
Can this PR be closed @garydgregory ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/47
Which JIRA issue is this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/59
Can this PR be closed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/82
Which JIRA issue is this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/91
For https://issues.apache.org/jira/browse/LOG4J2-1933
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/87
BTW, the test fails on Java 9:
```
2017-07-02 14:19:04,650
org.apache.logging.log4j.perf.jmh.Log4j2AppenderLatencyBenchmark.end2end-jmh-worker-1
ERROR Memo
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/87
Then I suggest that you raise the maximum latency, since it can obviously
happen.
And maybe this long latency on my machine is a flaw in the implementation?
---
If your
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/87
I tried to run:
```
java -jar log4j-perf/target/benchmarks.jar
".*Log4j2AppenderLatencyBenchmark.end2end" -f 1 -wi 1 -i 30 -t 2 -p
loggerType=MMap
```
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/81
To avoid breaking binary compatibility, we should not modify
public/protected constructors/methods of JsonLayout, XmlLayout, YamlLayout. Add
the new flag to the Builder only.
---
If
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/81
It would be nice to unit test this new feature for XmlLayout and YamlLayout
also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/81
Documentation in `layouts.xml.vm` should be updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/81
It would be nice to have the same functionality in XmlLayout and
YamlLayout. It should be easy to add that since they use the same Jackson based
framework.
---
If your project is set
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/81
Can you file an JIRA issue about this here:
https://issues.apache.org/jira/browse/LOG4J2/
and mention the JIRA issue here?
It would be good with some motivation why
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/79
It may be due to macros. When using Scala macros, you need to compile the
macro definitions separately from whatever using the macros. If src/main and
src/test are compiled together, it
Github user mikaelstaldal closed the pull request at:
https://github.com/apache/logging-log4j2/pull/80
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user mikaelstaldal opened a pull request:
https://github.com/apache/logging-log4j2/pull/80
Testing Travis CI
This is only a test for Travis CI.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/logging-log4j2 travis
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/79
That's strange. However, the Scala modules will soon be remove from this
repository (as they live in the logging-log4j-scala repo). So maybe we should
not spend time on fixing
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/79
Now it fails with the socket option test that has been fixed. Have you
synced with upstream?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/77
This has been fixed in master branch already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/67
I have fixed this in master branch, this PR can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/74
I suggest we place this in a new module "log4j-lucene" instead of in
log4j-nosql. We probably want to get rid of log4j-nosql, so we shouldn't put
new stuff in it.
---
48 matches
Mail list logo
