[GitHub] logging-log4j2 issue #110: JsonLayout support for custom key-value pairs bei...

2017-09-20 Thread mdvorak
Github user mdvorak commented on the issue: https://github.com/apache/logging-log4j2/pull/110 @mikaelstaldal is there any estimation on 2.10 release date? Obviously I need this :) ---

[GitHub] logging-log4j2 issue #110: JsonLayout support for custom key-value pairs bei...

2017-09-15 Thread mdvorak
Github user mdvorak commented on the issue: https://github.com/apache/logging-log4j2/pull/110 This is build log, it hangs after that.. But i'm not sure why I'm seeing this exception. https://gist.github.com/anonymous/9909ea92d10ac4ebe36f27a0610e7c2d ---

[GitHub] logging-log4j2 issue #110: JsonLayout support for custom key-value pairs bei...

2017-09-14 Thread mdvorak
Github user mdvorak commented on the issue: https://github.com/apache/logging-log4j2/pull/110 @mikaelstaldal Yeah i figured after digging deeper. Implemented it with correct support. Only thing that bugs me is that dynamically created LinkedHashMap - thats wasteful and

[GitHub] logging-log4j2 issue #110: JsonLayout support for custom key-value pairs bei...

2017-09-14 Thread mdvorak
Github user mdvorak commented on the issue: https://github.com/apache/logging-log4j2/pull/110 Partially, log4j-core completed successfully including all tests, whole project failed somewhere on Cassandra with some JNI exception. I did not look further into that yet. Does not seem

[GitHub] logging-log4j2 issue #110: JsonLayout support for custom key-value pairs bei...

2017-09-13 Thread mdvorak
Github user mdvorak commented on the issue: https://github.com/apache/logging-log4j2/pull/110 Link to JIRA issue: https://issues.apache.org/jira/browse/LOG4J2-1694 ---

[GitHub] logging-log4j2 issue #110: JsonLayout support for custom key-value pairs bei...

2017-09-13 Thread mdvorak
Github user mdvorak commented on the issue: https://github.com/apache/logging-log4j2/pull/110 @mikaelstaldal I've merged your tests, thanks for that! That saved some time. Anyway, I've pulled up my changes in `JsonLayout` to `AbstractJacksonLayout` - annotation

[GitHub] logging-log4j2 issue #110: JsonLayout support for custom key-value pairs bei...

2017-09-13 Thread mdvorak
Github user mdvorak commented on the issue: https://github.com/apache/logging-log4j2/pull/110 @mikaelstaldal I've looked at `GelfLayout`, and it resolves `${}` expressions during serialization. Is this really nescessary? Looks like pretty big overhead to me. I've teste

[GitHub] logging-log4j2 issue #110: JsonLayout support for custom key-value pairs bei...

2017-09-13 Thread mdvorak
Github user mdvorak commented on the issue: https://github.com/apache/logging-log4j2/pull/110 @mikaelstaldal Thanks, I looked for existing issue but somehow missed this one. I'll merge the branches and we'll see whether it will work for all cases. I did not know how to ma

[GitHub] logging-log4j2 issue #110: JsonLayout support for custom key-value pairs bei...

2017-09-12 Thread mdvorak
Github user mdvorak commented on the issue: https://github.com/apache/logging-log4j2/pull/110 Rolled back change of createLayout in eeebf4e, you are indeed correct about that one. ---

[GitHub] logging-log4j2 issue #110: JsonLayout support for custom key-value pairs bei...

2017-09-12 Thread mdvorak
Github user mdvorak commented on the issue: https://github.com/apache/logging-log4j2/pull/110 @garydgregory You are right, there is already `AdditionalField`, i'll rename it. There is however problem with pulling it up to `AbstractStringLayout`, since its used by many la

[GitHub] logging-log4j2 pull request #110: JsonLayout support for custom key-value pa...

2017-09-12 Thread mdvorak
GitHub user mdvorak opened a pull request: https://github.com/apache/logging-log4j2/pull/110 JsonLayout support for custom key-value pairs being inserted into JSON _Note: This is not ready PR, there are no unit tests for new feature - please review before i'll invest more time