Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/105
No real plan to upgrade to Java 8 for at least another year or so I
believe. Too many people still depending on 7 as a baseline. It would be neat
if there were some creative way to support
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/82
You can add docs to the [appenders
page](https://github.com/apache/logging-log4j2/blob/master/src/site/xdoc/manual/appenders.xml).
The basic format is HTML currently. You can just follow the
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/62
I'm not too experienced with Mongo either because I prefer not losing data,
but no worries, I'll take care of merging this now that I've got some time.
---
If your project is set
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/62
https://github.com/apache/logging-log4j2/blob/master/src/site/xdoc/manual/appenders.xml
is the appenders manual page which should be what you're looking for. Just
follow the patterns for h
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/62
Alright, everything looks fine to merge then. @mikaelstaldal you can merge
this if you have time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jvz commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/62#discussion_r126505047
--- Diff:
log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/mongodb/MongoDbProvider.java
---
@@ -21,50 +21,60 @@
import
Github user jvz commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/62#discussion_r126478075
--- Diff:
log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/mongodb/MongoDbProvider.java
---
@@ -93,130 +103,249 @@ public String
Github user jvz commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/62#discussion_r126476697
--- Diff:
log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/mongodb/MongoDbProvider.java
---
@@ -21,50 +21,60 @@
import
Github user jvz commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/62#discussion_r126476842
--- Diff:
log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/mongodb/MongoDbProvider.java
---
@@ -93,130 +103,249 @@ public String
Github user jvz commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/62#discussion_r126477831
--- Diff:
log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/mongodb/MongoDbProvider.java
---
@@ -93,130 +103,249 @@ public String
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/87
The Java 9 stuff sounds interesting. We may need to add a multi-version JAR
build for log4j-core as well (we have one for log4j-api so far) if it can't
reasonably done via reflection.
-
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/87
Thanks, we got notification of the ICLA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/47
Might need to add one. Should probably fall under a documentation bug type.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/87
I'll try to run those benchmarks on an AWS instance next week, though
that's not an ideal place to benchmark due to noisy neighbours and that sort of
thing.
---
If your project is set
Github user jvz commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/87#discussion_r124592044
--- Diff:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/ThreadHints.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/86
Depends if the constructors are private or not. For public ones where
having a default value for the new constructor doesn't make much sense,
deprecation is the way to go. When a sensible de
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/84
Can certainly be updated for that since it's not installed via apt-get.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/78
I've been pretty busy lately and haven't gotten to do anything on this
project in a little while. However, as mentioned, this PR can be merged by
anyone else. We don't have p
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/79
Not finding the `Logger$` class sounds like the Scala code isn't being
compiled properly. That's the companion object class name.
---
If your project is set up for it, you can rep
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/78
PR looks great! Ready to merge. Thanks for the clarifications regarding
serialization.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/75
Yikes, I totally forgot about this, sorry. This is ready to be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/78
Do you have java 9 installed? Make sure to follow the [setup
instructions](https://github.com/apache/logging-log4j2/blob/master/BUILDING.md).
As for the travis check, the thing below the comments
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/78
Code looks good. Can you add a unit test? Also, does the serialVersionUID
need to be changed, or is this a safe serialization change?
---
If your project is set up for it, you can reply to this
Github user jvz commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/71#discussion_r115505200
--- Diff:
log4j-core/src/main/java/org/apache/logging/log4j/core/layout/StringBuilderEncoder.java
---
@@ -32,9 +32,14 @@
public class
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/75
No worries about the travis bit, something is broken there at the moment.
The PR looks good, ready for merge, though I myself will not get a chance to do
this for at least a few hours if anyone
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/74
That makes sense. In the case of Elasticsearch (1.x, 2.x, and 5.x), you can
support all versions using the same code in certain scenarios (usually simple
things). If Lucene follows the usual
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/74
If Lucene's API is anything like Elasticsearch, then they don't bother
changing the package name between major versions and there are hacky ways to
support multiple versions.
-
Github user jvz commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/74#discussion_r113046338
--- Diff:
log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/lucene/LuceneAppender.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed to
Github user jvz commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/74#discussion_r113046801
--- Diff:
log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/lucene/LuceneAppender.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed to
Github user jvz commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/74#discussion_r113046710
--- Diff:
log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/lucene/LuceneAppender.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed to
Github user jvz commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/74#discussion_r113046093
--- Diff:
log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/lucene/LuceneAppender.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed to
Github user jvz commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/74#discussion_r113045904
--- Diff:
log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/lucene/LuceneAppender.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed to
Github user jvz commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/74#discussion_r113046499
--- Diff:
log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/lucene/LuceneAppender.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed to
Github user jvz commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/74#discussion_r113045520
--- Diff:
log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/lucene/LuceneAppender.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed to
Github user jvz commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/74#discussion_r113044694
--- Diff:
log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/lucene/LuceneAppender.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed to
Github user jvz commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/74#discussion_r113045083
--- Diff:
log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/lucene/LuceneAppender.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed to
Github user jvz commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/74#discussion_r113044838
--- Diff:
log4j-nosql/src/main/java/org/apache/logging/log4j/nosql/appender/lucene/LuceneAppender.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed to
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/73
This vaguely sounds like a log4j-nosql appender. I'd consider a similar one
for Elasticsearch to fall under that module.
---
If your project is set up for it, you can reply to this emai
38 matches
Mail list logo
