[GitHub] logging-log4net pull request #16: Implemented review comments given under Pu...

2017-08-21 Thread jbaehr
Github user jbaehr commented on a diff in the pull request: https://github.com/apache/logging-log4net/pull/16#discussion_r134177639 --- Diff: src/Appender/FileAppender.cs --- @@ -371,21 +371,22 @@ public abstract class LockingModelBase

[GitHub] logging-log4net issue #3: Support for types of non-parameterless constructor...

2017-06-08 Thread jbaehr
Github user jbaehr commented on the issue: https://github.com/apache/logging-log4net/pull/3 while I like the general idea, I have concerns regarding the ctor resolution. The current proposal works only with ctor arguments of type `String` and uses their names to find the right ctor