[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

2017-09-22 Thread jasontedor
Github user jasontedor commented on the issue: https://github.com/apache/logging-log4j2/pull/109 I can confirm that as well, both the unit tests we have that rely on this are passing now, and the application is logging the correct location when `%l` is used as a pattern. ---

[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

2017-09-04 Thread jasontedor
Github user jasontedor commented on the issue: https://github.com/apache/logging-log4j2/pull/109 Thanks @rgoers. ---

[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

2017-09-04 Thread jasontedor
Github user jasontedor commented on the issue: https://github.com/apache/logging-log4j2/pull/109 @MartyIX The bug report is linked [above](https://github.com/apache/logging-log4j2/pull/109#issuecomment-326626895). The bug manifests as that the source line on any logging event will

[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

2017-09-01 Thread jasontedor
Github user jasontedor commented on the issue: https://github.com/apache/logging-log4j2/pull/109 You're welcome @rgoers, it is my pleasure. I pushed a commit as we discussed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

2017-09-01 Thread jasontedor
Github user jasontedor commented on the issue: https://github.com/apache/logging-log4j2/pull/109 @rgoers Thanks for the feedback, that makes sense! I will do this: - make a change that will make that work - add a comment to the code that explains why the code is doing what

[GitHub] logging-log4j2 issue #109: Fix stack locator calc location on JDK 9

2017-09-01 Thread jasontedor
Github user jasontedor commented on the issue: https://github.com/apache/logging-log4j2/pull/109 This is for: https://issues.apache.org/jira/browse/LOG4J2-2028 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] logging-log4j2 pull request #109: Fix stack locator calc location on JDK 9

2017-09-01 Thread jasontedor
GitHub user jasontedor opened a pull request: https://github.com/apache/logging-log4j2/pull/109 Fix stack locator calc location on JDK 9 This commit fixes a bug in StackLocator#calcLocation on JDK 9. The particular issue here is that on JDK 9, all stack trace locations report