Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/114
Keep 'em coming :-)
---
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/114
I provided a different implementation. Tracking with
https://issues.apache.org/jira/browse/LOG4J2-2071
---
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/115
By me to boot!
---
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/111
Reference: https://issues.apache.org/jira/browse/LOG4J2-1216
---
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/110
We are in the process of releasing 2.9.1, anything beyond that does not
have a hard set date yet.
---
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/110
Hi,
Thank you for the PR. Did you run 'mvn clean install' successfully?
---
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/110
You should not change the createLayout() method which is already
deprecated. Adding new features is one of the main reasons we switched to the
builder pattern.
---
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/110
Note that in the GelfLayout, the field is called "AdditionalField". It
seems like a good idea to use the same name. Also, don't forget to update
/src/site/xdoc/manual/layouts.xml.vm
---
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/110
You're right, we do not want to say that all subclasses can or should
implement extra fields.
---
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/110
I wonder if the KeyValuePair[] should be pulled up from GelfLayout up to
its superclass AbstractStringLayout. This would let other layouts like
AbstractJacksonLayout use it since it
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/105
Fixed in Git master and tracked with
https://issues.apache.org/jira/browse/LOG4J2-2029
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/105
Our base requirement is still Java 7. So we cannot just yet take this whole
patch unless we split the examples into Java 7 and Java 8. I would like to take
the changes for the entry
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/108
I had to get some work done here, but yes, I have an almost fix that I can
get back to tonight. Please be patient ;-)
---
If your project is set up for it, you can reply to this email
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/108
Let me see if my current fix works, it needs more testing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/29
Sure, I was just looking ahead... ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/29
What if we wanted to use JAnsi with the status logger?
Gary
On Wed, Aug 16, 2017 at 1:44 PM, Mikael Ståldal
wrote:
> It would quite strange to hav
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/108
Swamped with work ATM. I will take a look later this week, but my initial
comment is the same: the duplication does not seen right.
---
If your project is set up for it, you can reply
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/108
Please see if your new test covers a different code path from the tests I
added in the **log4j-core-its** module in the package
**org.apache.logging.log4j.core.appender.net
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/107#discussion_r133317698
--- Diff:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/FileRenameAction.java
---
@@ -124,20 +124,22
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/108
I'm not crazy about some of the duplication and change in hierarchy. I'll
try to take a look. Also, no unit tests. I think we need those as well.
---
If your project is set
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/107#discussion_r133084320
--- Diff:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/FileRenameAction.java
---
@@ -124,11 +124,12
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/104
Agreed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/104#discussion_r130737396
--- Diff:
log4j-core/src/test/java/org/apache/logging/log4j/core/appender/HangingAppender.java
---
@@ -90,4 +90,8 @@ public boolean stop(final
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/103
The resources are still leaking if the tests fail midway through a method.
How about using try-with-resources clauses?
---
If your project is set up for it, you can reply to this email
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/101
Thank you for the patch.
In the future, please do not use redundant type arguments.
For example:
HashSet foo = new HashSet();
can simply be
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/93
Hi @ta924 Any news?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/59
@mikaelstaldal Yes, this can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/82
Is what is happening
in org.apache.logging.log4j.lucene5.appender.LuceneAppender.stop(long,
TimeUnit) not good enough?
Gary
On Mon, Jul 24, 2017 at 8:30 PM
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/82
Thank you for your submission @liyuj ! Can you try the "Lucene5" branch and
confirm that it works for you?
---
If your project is set up for it, you can reply to this emai
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/96
On Jul 21, 2017 21:36, "asfbot" wrote:
kenneth mcfarland on dev@logging.apache.org replies:
I noticed you created a JIRA for the 8012 buf size defualt. Is this
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/96
Thank you for your patch but I've already applied
https://github.com/apache/logging-log4j2/pull/95 Can you merge and resubmit SVP?
---
If your project is set up for it, you can rep
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/95
Thank you for your patch. Applied to Git master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/82
Can you provide any documentation for the new appender? That would help a
LOT! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/93
Hi. Were you able to create a sample jar for testing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/92
With this patch, I now get:
[ERROR] Failures:
[ERROR]
AsyncLoggerThreadContextGarbageFreeTest>AbstractAsyncThreadContextTestBase.testAsyncLogWritesToLog:
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/92
Please accept my apologies, I made a mistake saying the patch was partly
applied to log4j-api. It was not. The new test passes.
---
If your project is set up for it, you can reply to
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/92
I have the whole project sources and all modules (sources) loaded in
Eclipse so I run the one test directly from Eclipse.
The commands you show will never work (did you try
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/93#discussion_r127726686
--- Diff:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/ResolverUtil.java
---
@@ -210,11 +210,13 @@ public void
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/93#discussion_r127725532
--- Diff:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/ResolverUtil.java
---
@@ -329,6 +331,49 @@ private void
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/93#discussion_r127725284
--- Diff:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/ResolverUtil.java
---
@@ -210,11 +210,13 @@ public void
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/87
Most folks are unlikely to look to closely at the docs. IMO we should make
the docs as good as we can AND come up with default values that cover 80% of
the cases.
---
If your project
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/92
Hi,
When I build with 'mvn clean install' from a clean git master, all the
tests pass. Note that I am on Windows 10 and that the test HttpAppenderTest
fails randomly
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/92#discussion_r127092555
--- Diff:
log4j-core/src/test/java/org/apache/logging/log4j/core/layout/AbstractStringLayoutTest.java
---
@@ -59,12 +59,14 @@ public void
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/82
I created a branch called "lucene5" in git. Can you test this branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/62
Don't forget to update the docs please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/46
Sure, since https://issues.apache.org/jira/browse/LOG4J2-969 is closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/40
@surukuntu : Would you be so kind as to verify and close if master is up to
snuff?
I think this was covered by commit 0c9c9f384475af3402833e9a2a27e97248b84b38
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/82
Note that the idea with the "5" naming is to have both modules
log4j-lucene5 now and later log4j-lucene6
Gary
---
If your project is set up for it, you can reply to
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/82
Hi,
I can't recall if we have one but I brought in the code locally and started
fiddling with it.
Please see the Lucene 5 branch here:
https://gi
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/87
Thank you for running the benchmarks. Is this worth doing over on the
_current_ Java 8 runtime (_131)?
Gary
On Wed, Jul 5, 2017 at 6:59 AM, Remko Popma
wrote
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/88#discussion_r124051332
--- Diff:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java
---
@@ -83,6 +85,195
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/88#discussion_r124051928
--- Diff:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java
---
@@ -94,8 +285,10
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/88#discussion_r124051596
--- Diff:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java
---
@@ -83,6 +85,195
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/84
Curious, why not Maven 3.5.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/75
Thank you for you patch. It is now in Git master! :-) Keep them coming :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/82
I've created a new branch in our git repo called "Lucene5" based on your
PR. There are some changes and fixes to allow the build to run. This WIP and
not ready merg
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/77
Wouldn't this best be fixed with a JUnit assume?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/74
How about updating the patch to provide a new module log4j-lucene5?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/74
I was thinking that if you can use Java 8 then you depend on log4j-lucene6
and if you can't then log4j-lucene5.
---
If your project is set up for it, you can reply to this emai
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/74
And maybe even log4j-lucene5...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/74
Good to know! Thank you. I wonder if we should then create this under a
"lucene5" package so that we can have a "lucene6" package in a different module
if needed.
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/74
Why not use the current version of Lucene? Is the version you are using and
the latest (6.5.0) compatible?
---
If your project is set up for it, you can reply to this email and have
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/73
Can you please provide some JUnit tests? There are no tests ATM.
Thank you,
Gary
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/73#discussion_r112268957
--- Diff:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/lucene/LuceneAppender.java
---
@@ -0,0 +1,295
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/73
Thank you for your patch! Can you please redo this work as a patch to
provide a new module called "log4j-lucene"? This does not belong in our Core
module and we do not have
65 matches
Mail list logo
