Github user chlowell closed the pull request at:
https://github.com/apache/logging-log4net/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user chlowell commented on the issue:
https://github.com/apache/logging-log4net/pull/14
Glad the build works. I expect CI will be blocked until there's some
resolution for nunit/nunit3-vs-adapter#377, and I suppose there's also a
decision to make about the exclusi
Github user chlowell commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r134377119
--- Diff: tests/src/log4net.Tests.csproj ---
@@ -19,245 +18,25 @@
under the License.
-->
-http://schemas.microsoft.
Github user chlowell commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r134355177
--- Diff: tests/src/Context/LogicalThreadContextTest.cs ---
@@ -17,7 +17,7 @@
//
#endregion
-#if NET_4_5 || NETSTANDARD1_3
Github user chlowell commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r134354215
--- Diff: src/CompatibilityExtensions.cs ---
@@ -0,0 +1,53 @@
+#region Apache License
+//
+// Licensed to the Apache Software
Github user chlowell commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133848915
--- Diff: tests/src/log4net.Tests.csproj ---
@@ -19,245 +18,25 @@
under the License.
-->
-http://schemas.microsoft.
Github user chlowell commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133846257
--- Diff: src/Appender/AppenderSkeleton.cs ---
@@ -321,7 +321,7 @@ public void DoAppend(LoggingEvent loggingEvent
Github user chlowell commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133846136
--- Diff: src/CompatibilityExtensions.cs ---
@@ -0,0 +1,53 @@
+#region Apache License
+//
+// Licensed to the Apache Software
Github user chlowell commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133845941
--- Diff: tests/src/Context/LogicalThreadContextTest.cs ---
@@ -17,7 +17,7 @@
//
#endregion
-#if NET_4_5 || NETSTANDARD1_3
GitHub user chlowell opened a pull request:
https://github.com/apache/logging-log4net/pull/14
Add .NET Standard 2.0 build
This adds a netstandard2.0 build consumable on .NET Core 2.0, .NET
Framework 4.6.1+, Xamarin platforms, and the next version of UWP ([this
doc](https
10 matches
Mail list logo
