[GitHub] logging-log4j2 issue #107: Mark FileRenameAction as successful when using al...

2017-08-15 Thread benji
Github user benji commented on the issue: https://github.com/apache/logging-log4j2/pull/107 Changes are ready, let me know. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] logging-log4j2 pull request #107: Mark FileRenameAction as successful when u...

2017-08-14 Thread benji
Github user benji commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/107#discussion_r133093011 --- Diff: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/FileRenameAction.java --- @@ -124,11 +124,12 @@ public

[GitHub] logging-log4j2 pull request #107: Mark FileRenameAction as successful when u...

2017-08-14 Thread benji
GitHub user benji opened a pull request: https://github.com/apache/logging-log4j2/pull/107 Mark FileRenameAction as successful when using alternative ways to mo… If the primary strategy for moving a file (Files.move) fails, then the code tries other strategies but never returned