Re: Pull Request for [LOG4J2-2405] Better handling of %highlight pattern when using jul-bridge

2018-11-06 Thread Marco Herrn
t;> > >> Marco: Thank you for updating your PR. > >> Remko: The PR has been changed to use String keys instead of Levels. LGTM. > >> WDYT? > >> > >> Gary > >> > >>> On Thu, Oct 25, 2018 at 12:57 AM Marco Herrn wrote: > &g

Re: Pull Request for [LOG4J2-2405] Better handling of %highlight pattern when using jul-bridge

2018-10-24 Thread Marco Herrn
sed later, the name-based > lookup will find the associated style. > > Remko. > > (Shameless plug) Every java main() method deserves http://picocli.info > > > On Oct 24, 2018, at 21:31, Marco Herrn wrote: > > > > Hello, > > > > I have prepared

Pull Request for [LOG4J2-2405] Better handling of %highlight pattern when using jul-bridge

2018-10-24 Thread Marco Herrn
Hello, I have prepared a pull request for LOG4J2-2405. There is still one decision to be made how to handle custom log levels. I added my comments to the pull request, but duplicate it here to have a broader audience for discussing it: To allow styles for unknown log levels the HighlightConverte

Pull Request for [LOG4J2-2403] Allow zero padding the counter of a RollingFileAppender

2018-10-24 Thread Marco Herrn
Marco On Tue, Oct 23, 2018 at 04:01:50PM +0200, Marco Herrn wrote: > Hi, > > I am preparing a pull request for LOG4J2-2403 and modified an existing > Unit-Test that has its configuration in YAML format. I added a second > ListAppender, but this causes the Unit test to behave str