Github user EbenZhang commented on the issue:
https://github.com/apache/logging-log4net/pull/13
Added couple of unit tests for the subfolder. In order to easily write new
unit tests, I did some refactoring.
---
Github user EbenZhang commented on the issue:
https://github.com/apache/logging-log4net/pull/13
>What about rolling by date in combination with subdirectories? What if the
file should be rolled by date and be placed in a subdirectory that contains the
rolling date?
Is th
Github user EbenZhang commented on the issue:
https://github.com/apache/logging-log4net/pull/13
was extremely busy these days.days will have a look of your comments as
soon as I get chance.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user EbenZhang commented on the issue:
https://github.com/apache/logging-log4net/pull/13
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user EbenZhang commented on the issue:
https://github.com/apache/logging-log4net/pull/13
My branch is already based on the `Develop` branch. The whitespace issue is
not fixed in `Develop` branch, see the source code on GitHub
https://raw.githubusercontent.com/apache
GitHub user EbenZhang reopened a pull request:
https://github.com/apache/logging-log4net/pull/13
Support combination of roll by size, preserve file extension and folder
[LOG4NET-571](https://issues.apache.org/jira/browse/LOG4NET-571)
You can merge this pull request into a Git
Github user EbenZhang closed the pull request at:
https://github.com/apache/logging-log4net/pull/13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user EbenZhang commented on the issue:
https://github.com/apache/logging-log4net/pull/13
> I fixed all whitespace issues in the develop branch
seems you have fixed it in the RollingFileAppenderNG branch, not the
develop, should I base on RollingFileAppenderNG?
GitHub user EbenZhang opened a pull request:
https://github.com/apache/logging-log4net/pull/13
Support combination of roll by size, preserve file extension and folder
[LOG4NET-571](https://issues.apache.org/jira/browse/LOG4NET-571)
You can merge this pull request into a Git
[
https://issues.apache.org/jira/browse/LOG4NET-571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
EbenZhang updated LOG4NET-571:
--
Description:
Those three don't work well together, the oldest file won't be deleted, e.g.
EbenZhang created LOG4NET-571:
-
Summary: Rolling by size, Preserve Extension, and Folder don't
work together
Key: LOG4NET-571
URL: https://issues.apache.org/jira/browse/LOG4NET-571
Project: Lo
11 matches
Mail list logo
