Re: [VOTE] Release Apache Log4j Scala 13.1.0

2024-02-05 Thread Christian Grobmeier
Did basic checks only, but +1 On Mon, Feb 5, 2024, at 21:53, Piotr P. Karwasz wrote: > Hi Volkan, > > On Thu, 1 Feb 2024 at 11:32, Volkan Yazıcı wrote: >> >> This is a vote to release the Apache Log4j Scala 13.1.0. >> >> Website: https://logging.staged.apache.org/log4j/scala >> GitHub: https:/

Re: Revamp of asynchronous logging

2024-02-05 Thread Matt Sicker
For #3, I agree that we should perform formatting on the application thread before transferring control to an asynchronous thread. > On Feb 5, 2024, at 14:49, Piotr P. Karwasz wrote: > > Hi all (and especially Remko), > > Lately I spent some time looking at the asynchronous logger/logger > con

Re: [VOTE] Release Apache Log4j Scala 13.1.0

2024-02-05 Thread Piotr P. Karwasz
Hi Volkan, On Thu, 1 Feb 2024 at 11:32, Volkan Yazıcı wrote: > > This is a vote to release the Apache Log4j Scala 13.1.0. > > Website: https://logging.staged.apache.org/log4j/scala > GitHub: https://github.com/apache/logging-log4j-scala > Commit: abf3b13d3692b45d221dc78202c34f00f8f9124f > Distrib

Revamp of asynchronous logging

2024-02-05 Thread Piotr P. Karwasz
Hi all (and especially Remko), Lately I spent some time looking at the asynchronous logger/logger config and I think it could profit from some refactoring in 3.x. The problems I am seeing are: 1. The disruptors of `AsyncLogger` and `AsyncLoggerConfig` use different structures. The disruptor of `

Re: [log4j] Nested logging and async. message formatting

2024-02-05 Thread Piotr P. Karwasz
Hi Volkan, On Mon, 5 Feb 2024 at 20:13, Volkan Yazıcı wrote: > What about the other two issues I mentioned: > >1. `log4j2.formatMsgAsync` and `@AsynchronouslyFormattable` don't always >work (`log4j2.formatMsgAsync=false` is ignored for reusable messages, which >are formatted always ea

Re: [log4j] Nested logging and async. message formatting

2024-02-05 Thread Piotr P. Karwasz
Hi Volkan, On Mon, 5 Feb 2024 at 16:18, Volkan Yazıcı wrote: > I thought of matching the behavior between the two log event factories by > making the `DefaultLogEventFactory` format the message at creation. This > would imply both message factories will be formatting the message eagerly. > (Forma

Re: [VOTE] Release Apache Log4j Scala 13.1.0

2024-02-05 Thread Volkan Yazıcı
I need 2 +1's from PMC members to make this release happen. We are on the 5th day and I am still yet to hear a reaction. I also shared the commands PMC members need to run to review the release. Is there anything else I need to provide? Could you help by voting, please? On Thu, Feb 1, 2024 at 11:3

Re: [log4j] Nested logging and async. message formatting

2024-02-05 Thread Volkan Yazıcı
Okay, nested logging is officially not supported. I will remove the nested logging tests blocking the `2.x-StatusLogger-revamp` branch. What about the other two issues I mentioned: 1. `log4j2.formatMsgAsync` and `@AsynchronouslyFormattable` don't always work (`log4j2.formatMsgAsync=false` i

Re: [log4j] Nested logging and async. message formatting

2024-02-05 Thread Ralph Goers
On 2024/02/05 15:17:29 Volkan Yazıcı wrote: > > AFAIK, nested logging is not a documented feature. Yet one can find several > tickets people has filed issues that were fixed by us. Hence, it is safe to > conclude that it is used. You are correct that it is not documented. Nor should it be. As

[log4j] Nested logging and async. message formatting

2024-02-05 Thread Volkan Yazıcı
*Abstract:* Nested logging does not always work, it conflicts with `log4j2.formatMsgAsync`, and I need help on fixing it. *Problem description* Nested logging – that is, while trying to `log()`, exception/argument/message access invokes `log()` too – only works with message factories that eagerly