Re: Requiring signed commits

2023-01-15 Thread Volkan Yazıcı
It sounds like we have a lazy consensus here. Piotr, I see your point. I think we need to point this out in a GitHub Pull Request template , whi

Re: Import order and POM formatting

2023-01-15 Thread Volkan Yazıcı
For the import order, note that Spotless configuration is aligned with `.editorconfig` in `log4j-tools`. I find this pretty important and it took me a while to get them working in the same way. Once we ship Spotless and `.editorconfig` hand in hand, given we all use IDEA and it has pretty decent `.

Re: Builder methods: should we use setFoo, withFoo, foo, or else?

2023-01-15 Thread Volkan Yazıcı
I see two kinds of accessor patterns in the wild: 1. `int getX()` and `setX(int x)` on mutable objects 2. `int x()` and `withX(int x)` on immutable objects With records, Java gravitates towards `int x()` and `with { x = x' }`, aka. withers