Re: Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution

2022-11-10 Thread Gary Gregory
I've used XInclude in the past at work and in some FOSS projects and it works great. The wrinkle is to guard against what is included to avoid CVEs. Same issue with DTDs. Gary On Thu, Nov 10, 2022, 13:40 Ralph Goers wrote: > I’ve suggested to Volkan that he look to see if the changes plugin >

Re: Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution

2022-11-10 Thread Ralph Goers
I’ve suggested to Volkan that he look to see if the changes plugin supports XIncludes in changes.xml and if it doesn’t how much work it would be to add it. Ralph > On Nov 10, 2022, at 10:36 AM, Matt Sicker wrote: > > It’s manual work that makes merging PRs non-trivial. > >> On Nov 9, 2022, at

Re: Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution

2022-11-10 Thread Matt Sicker
It’s manual work that makes merging PRs non-trivial. > On Nov 9, 2022, at 10:58 PM, Ralph Goers wrote: > > It is, but it isn’t one of the items that I personally consider broken. > > Ralph > >> On Nov 9, 2022, at 3:50 PM, Matt Sicker wrote: >> >> The changelog is an important aspect of the w