On Tue, 13 Sept 2022 at 02:24, Ralph Goers wrote:
> 1. SLF4J2 support to make the Junit dependency test scope.
I fixed it yesterday, but if someone else can do a `mvn
dependency:list -DincludeScope=runtime` and look for dependencies that
should not be there, it would be better.
> 2. Fix GelfLayo
Unfortunately, I cancelled the vote for that. I need fixes for
1. SLF4J2 support to make the Junit dependency test scope.
2. Fix GelfLayoutTest on Windows.
If someone can let me know when these are fixed I will create a new release
candidate.
Ralph
> On Sep 12, 2022, at 5:01 PM, Gary Gregory w
Hi Piotr,
I see in the release notes that the fix made it in 2.19.0 RC1, thank you!
Gary
On Thu, Jul 21, 2022, 17:33 Gary Gregory wrote:
> Hi Piotr,
>
> Thank you so much for the quick analysis!
>
> Gary
>
>
> On Thu, Jul 21, 2022, 17:35 Piotr P. Karwasz
> wrote:
>
>> Hi Gary,
>>
>> > The scr
Hi Gary,
On Tue, 13 Sept 2022 at 00:05, Gary Gregory wrote:
>
> I did get other errors in core but they are intermittent so I only want to
> figure out what is the problem with these since they happen every time.
The culprit might be the `json-unit` bump I performed:
https://github.com/apache/lo
I did get other errors in core but they are intermittent so I only want to
figure out what is the problem with these since they happen every time.
Gary
On Mon, Sep 12, 2022, 13:26 Matt Sicker wrote:
> Are you getting any other test failures besides the GelfLayoutTest one?
>
> On Mon, Sep 12, 20
Wonderful. That really needs to be fixed so this vote will have to be
cancelled. Also, can someone fix the test Gary is having a problem with?
Ralph
> On Sep 12, 2022, at 2:20 PM, Piotr P. Karwasz wrote:
>
> Hi Ralph,
>
> On Sat, 10 Sept 2022 at 00:56, Ralph Goers wrote:
>> Maven Artifacts
Hi Ralph,
On Sat, 10 Sept 2022 at 00:56, Ralph Goers wrote:
> Maven Artifacts:
> https://repository.apache.org/content/repositories/orgapachelogging-1088/
I think I left a big bug in log4j-slf4j2-impl/pom.xml: the JUnit
artifacts are in the compile scope.
Piotr
Are you getting any other test failures besides the GelfLayoutTest one?
On Mon, Sep 12, 2022 at 11:24 AM Gary Gregory wrote:
>
> Check, I am using Java 8 (with a Maven toolchain obviously).
>
> Gary
>
> On Mon, Sep 12, 2022, 08:45 Ralph Goers wrote:
>
> > I believe Matt is referring to the error
On Mon, Sep 12, 2022 at 11:10 AM Ralph Goers wrote:
> While that might be true, we don’t use Jenkins for our builds anymore.
> Instead, they all fail with GitHub actions instead of failing with Jenkins.
It's a Maven plugin.
Hi,
On Mon, 12 Sept 2022 at 18:05, Ralph Goers wrote:
> See below. While I OK with reorganizing the parent pom.xml in release-2.x I
> am not
> OK with making radical changes to it since it is “stable”. I also think
> trying to synchronize
> the two is kind of pointless. Given that one is base
You can find more about CI-friendly versioning and ${revision} here:
https://maven.apache.org/maven-ci-friendly.html
In a nutshell, you only define the `revision` property in the parent POM's
`` block and refer to it everywhere you need to literally type
the version.
On Mon, Sep 12, 2022 at 2:49
Check, I am using Java 8 (with a Maven toolchain obviously).
Gary
On Mon, Sep 12, 2022, 08:45 Ralph Goers wrote:
> I believe Matt is referring to the errors Ron saw when trying to only use
> Java 11.
> The errors you saw Gary would be an entirely different matter.
>
> Ralph
>
> > On Sep 12, 202
> On Sep 12, 2022, at 8:49 AM, Matt Sicker wrote:
>
> There's a neat plugin from the Jenkins project for making stable
> identifiers for CI builds that might be interesting:
> https://github.com/jenkinsci/incrementals-tools
While that might be true, we don’t use Jenkins for our builds anymore
> On Sep 12, 2022, at 2:52 AM, Volkan Yazıcı wrote:
>
> Totally agreed with all the points!
>
> I would like to extend this a bit more:
>
> * switch to CI-friendly versions via ${revision}
I don’t understand this. What is a “CI-friendly version”. What do you mean by
${revision}.
Surely al
See below. While I OK with reorganizing the parent pom.xml in release-2.x I am
not
OK with making radical changes to it since it is “stable”. I also think trying
to synchronize
the two is kind of pointless. Given that one is based on Java 8 and one is Java
11
and the organization of the proj
There's a neat plugin from the Jenkins project for making stable
identifiers for CI builds that might be interesting:
https://github.com/jenkinsci/incrementals-tools
On Mon, Sep 12, 2022 at 7:49 AM Piotr P. Karwasz
wrote:
>
> Hi Volkan,
>
> On Mon, 12 Sept 2022 at 11:53, Volkan Yazıcı wrote:
> >
I believe Matt is referring to the errors Ron saw when trying to only use Java
11.
The errors you saw Gary would be an entirely different matter.
Ralph
> On Sep 12, 2022, at 8:41 AM, Matt Sicker wrote:
>
> The sun.reflect test error is due to running Maven using Java 11.
> You'll need to run M
The sun.reflect test error is due to running Maven using Java 11.
You'll need to run Maven using Java 8 (so that it's used as the
default compiler for all the modules that don't override the toolchain
to use) with Java 11 as a toolchain entry to compile the Java 9 and
Java 11 modules.
On Mon, Sep
I'm not sure I understand, but the bottom line is I can't build the release
from sources. Surely we can't say that disabling tests to validate or build
a release is ok?
Gary
On Sun, Sep 11, 2022, 16:46 Matt Sicker wrote:
> I get the same error when running on java 11, too, but that’s to be
> ex
Hi Volkan,
On Mon, 12 Sept 2022 at 11:53, Volkan Yazıcı wrote:
> I would like to extend this a bit more:
>
> * switch to CI-friendly versions via ${revision}
I am not sure, what do you mean by that: do we put ${revision} instead
of the current Log4j2 version?
Piotr
Totally agreed with all the points!
I would like to extend this a bit more:
* switch to CI-friendly versions via ${revision}
* group properties by domain (e.g., common, lib versions, plugin versions)
and lexicographically sort each group
On Mon, Sep 12, 2022 at 9:11 AM Piotr P. Karwasz
wrote:
Hi,
On Tue, 6 Sept 2022 at 22:40, Piotr P. Karwasz wrote:
> What do you think about adding the `log4j-api-test` and
> `log4j-core-test` modules also in `release-2.x`? This should limit the
> number of conflicts to the differences that matter.
It would be also nice to synchronise the `pom.xml` of
22 matches
Mail list logo
