Re: Sync `master` and `release-2.x` test structure

2022-09-06 Thread Ralph Goers
I am fine with this but please create a Jira issue for removing support for 1.8. It needs to show up in the changelog. Ralph > On Sep 6, 2022, at 1:57 PM, Piotr P. Karwasz wrote: > > On Tue, 6 Sept 2022 at 22:53, Ralph Goers wrote: >> I don’t have an issue with that but Spring has requested a

Re: Sync `master` and `release-2.x` test structure

2022-09-06 Thread Piotr P. Karwasz
On Tue, 6 Sept 2022 at 22:53, Ralph Goers wrote: > I don’t have an issue with that but Spring has requested a release from us > that supports > SLF4J 2.0 this week. So I am going through Jira issues looking for those that > warrant > my attention before the release. What about: https://github.c

Re: Sync `master` and `release-2.x` test structure

2022-09-06 Thread Matt Sicker
The structure was a limitation due to testing modules. I suppose this would depend on how relevant the tests form master will be in 2.x over time. — Matt Sicker > On Sep 6, 2022, at 13:40, Piotr P. Karwasz wrote: > > Hi, > > Due to the difference in the project structure between `master` and

Re: Sync `master` and `release-2.x` test structure

2022-09-06 Thread Ralph Goers
I don’t have an issue with that but Spring has requested a release from us that supports SLF4J 2.0 this week. So I am going through Jira issues looking for those that warrant my attention before the release. So I would ask we save this until after the release. Ralph > On Sep 6, 2022, at 1:40

Sync `master` and `release-2.x` test structure

2022-09-06 Thread Piotr P. Karwasz
Hi, Due to the difference in the project structure between `master` and `release-2.x`, most cherry-picks between the two lines fail. What do you think about adding the `log4j-api-test` and `log4j-core-test` modules also in `release-2.x`? This should limit the number of conflicts to the difference