Re: Source location static inlining

2022-07-09 Thread Ralph Goers
> On Jul 9, 2022, at 11:16 AM, Ralph Goers wrote: > > I’ve been thinking about this a lot. There are a few issues. > > 1. I’d like to not have to generate new source code for every class doing > logging. > I am not sure how Lombok does it but I will want to investigate that. > 2. Your solut

Re: Source location static inlining

2022-07-09 Thread Ralph Goers
I’ve been thinking about this a lot. There are a few issues. 1. I’d like to not have to generate new source code for every class doing logging. I am not sure how Lombok does it but I will want to investigate that. 2. Your solution looks like it is still done at runtime. I would like to do it a

Re: Source location static inlining

2022-07-09 Thread Piotr P. Karwasz
Hi Volkan, On Sat, 9 Jul 2022 at 12:05, Volkan Yazıcı wrote: > I think we can extend this experiment to implement zero-cost source > location capture for Log4j. Though I will appreciate your help on some > loose ends. Assuming we have a bullet-proof mechanism to inline source > location capture g

Re: Source location static inlining

2022-07-09 Thread Remko Popma
It would be truly awesome to get this to work! Triple yay! I would keep it as simple as possible though, and not worry too much about being super user friendly. Asking folks to recompile to get this feature is not a big ask, and avoiding complexity like weaving is a big advantage. Not working for

Re: Source location static inlining

2022-07-09 Thread Gary Gregory
There might be something to reuse from https://projectlombok.org/ Gary On Sat, Jul 9, 2022, 06:05 Volkan Yazıcı wrote: > Inspired by this SO post > and > with some help from Piotr , > I > have drafted a

Source location static inlining

2022-07-09 Thread Volkan Yazıcı
Inspired by this SO post and with some help from Piotr , I have drafted an example where I redefine a class such that every logger call is preceded with a static source location capture. The experiment aims