Re: [General] What is logging?

2022-06-12 Thread Stephen Webb
Good job Robert. It frustrates me that the (essential) importance of logging is not emphasised sufficiently in introductory software engineering. This is a help towards getting the message out. My suggestion would be to mention runtime configuration of filtering and enabling of loggers earlier in

Re: Compile `release-2.x` with JDK 11

2022-06-12 Thread Matt Sicker
Just see some of the commits in master that made that buildable in newer JDKs for ideas on what things need to be updated in 2.x for similar convenience. I’m not so sure about the release process requiring Java 11, but I’d support having this offered for convenience. Really, any build enhancemen

Re: Compile `release-2.x` with JDK 11

2022-06-12 Thread Tim Perry
Piotr, I did a troll back through the history of the maven artifact in question and I can see one of the admins removed the following line from the pom.xml because it broke compilation with Java 8: 8 As you correctly guessed, this meant API compatibility wasn't checked when building with Java 1

Re: Compile `release-2.x` with JDK 11

2022-06-12 Thread Piotr P. Karwasz
Hi Tim, On Sun, 12 Jun 2022 at 20:32, Tim Perry wrote: > I've run into an issue where javac 11+ will emit valid java 8 code for > functions that weren't added to Java until after java 8. When the code is > run on Java 8 runtime errors appear complaining about functions missing > from classes that

Re: Compile `release-2.x` with JDK 11

2022-06-12 Thread Tim Perry
Yes, that looks like it would address my concern. Thank you. > On Jun 12, 2022, at 11:43 AM, Volkan Yazıcı wrote: > > Can't we perform this check via configuring animal-sniffer-maven-plugin > to > work with the `java18` sign

Re: Compile `release-2.x` with JDK 11

2022-06-12 Thread Volkan Yazıcı
Can't we perform this check via configuring animal-sniffer-maven-plugin to work with the `java18` signature ? On Sun, Jun 12, 2022 at 8:32 PM Tim Perry wrot

Re: Compile `release-2.x` with JDK 11

2022-06-12 Thread Tim Perry
I've run into an issue where javac 11+ will emit valid java 8 code for functions that weren't added to Java until after java 8. When the code is run on Java 8 runtime errors appear complaining about functions missing from classes that are part of the JRE. Most recently I ran into this when I used j

Re: Compile `release-2.x` with JDK 11

2022-06-12 Thread Volkan Yazıcı
Using a recent JDK, yet targeting 8 is a great idea Piotr! I brought up this subject a couple of times in the video calls, though, as far as I recall, the excuse was mostly the fact that Java 11 work is aimed for 3.x and the lack of time. Personally, I would even favor using Java 17 and configurin

Re: Compile `release-2.x` with JDK 11

2022-06-12 Thread Andrew Marlow
On Sun, 12 Jun 2022 at 12:13, Piotr P. Karwasz wrote: > Hi all, > > Currently the `release-2.x` branch must be run using JDK 8 and uses > Maven's toolchains to compile Java 9+ code. [snip] Maybe we could switch to > compiling `release-2.x` using Java 11 with the `--release 8` after > 2.18.0 i

Compile `release-2.x` with JDK 11

2022-06-12 Thread Piotr P. Karwasz
Hi all, Currently the `release-2.x` branch must be run using JDK 8 and uses Maven's toolchains to compile Java 9+ code. This has many drawbacks: * It is difficult for new contributors to run the build process, * It requires a change to `JAVA_HOME` each time we build `release-2.x`. I suppose most