Re: Consuming our own BOM

2022-05-27 Thread Matt Sicker
To avoid rearranging all the directories, I'm moving the parent pom to its own directory, moving the bom pom to the root, and updating the rest of the poms to know where the old parent pom now is. On Thu, May 19, 2022 at 3:08 PM Matt Sicker wrote: > > Agreed. I added the BOM POM later on and didn

Is there a way for Dependabot to use its own fork or something?

2022-05-27 Thread Matt Sicker
The fact that the bot uses branches in our repo rather than a fork of the repo causes a shitload of bot spam.

Re: 3.x plugins

2022-05-27 Thread Matt Sicker
And I think one bit of confusion with plugin keys/names/etc. is that this is mostly relevant for either Core plugins (since that determines the element name used in configurations) or for any other plugin namespace that uses aliases for plugin classes, though some of those plugin namespaces defi

Re: 3.x plugins

2022-05-27 Thread Matt Sicker
1. Plugin key is separate from the plugin name due to automatically filling in some info from elementType, though I've rearranged the code a bit in 3.x to make this part less confusing. 2. It's only @Configurable (Core) plugins that use the element type, printable, and deferChildren options. I cou

Re: 3.x plugins

2022-05-27 Thread Ralph Goers
> On May 27, 2022, at 6:54 AM, Volkan Yazıcı wrote: > > Matt, some more questions/remarks: > > 1. AFAIU, plugin `key` is the normalized `name`. Right? If so, what is > the purpose of the `name`? See PluginElementVisitor (at least in 2.x) @Override public PluginEntry visitType(final TypeE

Re: 3.x plugins

2022-05-27 Thread Volkan Yazıcı
Matt, some more questions/remarks: 1. AFAIU, plugin `key` is the normalized `name`. Right? If so, what is the purpose of the `name`? 2. I was expecting `PluginEntry` to be simplified similar to `Plugin` and only contain a `String key`, `String name`, and `String className`. For `@Co