Re: 3.x plugins

2022-05-22 Thread Matt Sicker
Those lazy wrappers are an insignificant detail. Feel free to simplify. Configurable is a namespace annotation, not a name annotation. Plugin is a name annotation that gets indexed. If you’d like fancier conditional annotations, please describe what parts you want. I don’t want to port over eve

Re: 3.x plugins

2022-05-22 Thread Volkan Yazıcı
Great work Matt! I have some questions/remarks: 1. Why did we introduce `LazyInt`, `LazyBoolean`, etc. rather than simply leveraging `Lazy`? If the concern is nullability, we could have checked the `supplier` response against `null` in `Lazy` itself. 2. Why is `Configurable` not annota

Review Request: LOG4J2-3502 Add JMPS support to JTL

2022-05-22 Thread Volkan Yazıcı
Would somebody review #849 where I add JPMS support to JTL (according to Ralph's instructions shared in LOG4J2-3502 ), please?