Re: Upgradable dependencies

2022-05-02 Thread Piotr P. Karwasz
Hello Volcan, On Fri, 29 Apr 2022 at 22:04, Volkan Yazıcı wrote: > I have raised this issue in the past. I even came up with a proposal on the > repository structure > to be > followed. I am a big proponent of breaking up the log

Re: Please verify your stuff.

2022-05-02 Thread Matt Sicker
As for this particular issue, I also discovered it yesterday and added the async stuff to the ignore list on that test for now in master. I see you updated the XSD as that was the other way to fix the test. :) On Mon, May 2, 2022 at 10:21 AM Matt Sicker wrote: > > We don't block PRs or commits ba

Re: Please verify your stuff.

2022-05-02 Thread Matt Sicker
We don't block PRs or commits based on CI status. We use CTR, so it's the responsibility of each committer to run the tests locally before pushing upstream. It also doesn't help that as of now, CI takes 4x as long to build and run the tests than it does on my machine. Plus, CI is flaky sometimes (

Re: Please verify your stuff.

2022-05-02 Thread Xeno Amess
I mean, even though some guy make it fails locally, CI shall stop manager for merging that pr, shouldn't it? XenoAmess From: Xeno Amess Sent: Monday, May 2, 2022 9:23:11 PM To: dev@logging.apache.org Subject: Re: Please verify your stuff. I don't understand. Wh

Re: Please verify your stuff.

2022-05-02 Thread Xeno Amess
I don't understand. What is CI doing? XenoAmess From: Ralph Goers Sent: Monday, May 2, 2022 8:58:50 PM To: dev@logging.apache.org Subject: Please verify your stuff. Remko, Did you run a full build of master when you committed your latest changes? I don’t see h

Please verify your stuff.

2022-05-02 Thread Ralph Goers
Remko, Did you run a full build of master when you committed your latest changes? I don’t see how. I am getting failures in XmlSchemaTest. It seems AsyncWaitStrategyIncorrectFactoryConfigTest.xml, AsyncWaitStrategyFactoryConfigGlobalLoggerTest.xml, AsyncWaitStrategyFactoryConfigTest.xml, an