Re: Trying to Test and Build release-2.x Failing Locally

On Thu, 21 Apr 2022 at 20:15, Mohammed B wrote: > > org.apache.logging.log4j.util.ServiceLoaderUtilTest.testBrokenServiceFile(ServiceLoaderUtilTest.java:85) > > Is this supposed to happen? > > Yes, you can ignore it for now. I'll improve the test. Piotr

Re: Trying to Test and Build release-2.x Failing Locally

The way I have it set up is to have Java 8 and 11 in my toolchain. I don't point a different Java version to 11. Gary On Thu, Apr 21, 2022, 14:26 Mohammed B wrote: > java version "14.0.1" 2020-04-14 > Java(TM) SE Runtime Environment (build 14.0.1+7) > Java HotSpot(TM) 64-Bit Server VM (build 1

Re: Trying to Test and Build release-2.x Failing Locally

Thank you all. I think I got everything fairly set up. On Thu, Apr 21, 2022 at 9:26 PM Mohammed B wrote: > java version "14.0.1" 2020-04-14 > Java(TM) SE Runtime Environment (build 14.0.1+7) > Java HotSpot(TM) 64-Bit Server VM (build 14.0.1+7, mixed mode, sharing) > > Do you I need to change the

Re: Trying to Test and Build release-2.x Failing Locally

java version "14.0.1" 2020-04-14 Java(TM) SE Runtime Environment (build 14.0.1+7) Java HotSpot(TM) 64-Bit Server VM (build 14.0.1+7, mixed mode, sharing) Do you I need to change the path to point the bin folder of java 8 also? On Thu, Apr 21, 2022 at 9:18 PM Matt Sicker wrote: > I'm not so sure

Re: Trying to Test and Build release-2.x Failing Locally

I'm not so sure about that; that's a fairly recently added test. What's the output you get for `java -version`? On Thu, Apr 21, 2022 at 1:15 PM Mohammed B wrote: > > Ok now it's working but one of the tests is failing: > > [INFO] Running org.apache.logging.log4j.AbstractLoggerTest > [ERROR] Tests

Re: Trying to Test and Build release-2.x Failing Locally

Ok now it's working but one of the tests is failing: [INFO] Running org.apache.logging.log4j.AbstractLoggerTest [ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.183 s <<< FAILURE! - in org.apache.logging.log4j.util.ServiceLoaderUtilTest [ERROR] org.apache.logging.log4j.uti

Re: Trying to Test and Build release-2.x Failing Locally

Also set your JAVA_HOME to the Java 8 distribution when running maven here as many modules in 2.x assume they're compiled via Java 8, not via toolchains. On Thu, Apr 21, 2022 at 12:59 PM Mohammed B wrote: > > I still get the same error. This is my toolchains.xml now: > > > > > jdk >

RE: does the master branch compile?

> -Original Message- > From: Matt Sicker > Sent: Thursday, April 21, 2022 1:31 PM > To: Apache Logging Developers List > Subject: Re: does the master branch compile? > > You've only got two copies of the git checkout? If I knew of better > ways of keeping works in progress stored in Git

Re: Trying to Test and Build release-2.x Failing Locally

I still get the same error. This is my toolchains.xml now: jdk 14 sun C:\Program Files\Java\jdk-14.0.1 jdk 9 sun C:\Program Files\Java\jdk-14.0.1 jdk 8 eclipse C:\Program Files\Eclipse Ado

Re: Trying to Test and Build release-2.x Failing Locally

What I've done in my own toolchains file before is setting a version of Java for both "1.8" and "8" along with an entry for version "9" (but pointing to Java 11) and "11". In the master branch, this test was since updated to stop referring to the removed class as that branch requires Java 11 as th

Re: does the master branch compile?

You've only got two copies of the git checkout? If I knew of better ways of keeping works in progress stored in Git other than `git stash`, I wouldn't have so many local copies myself. On Thu, Apr 21, 2022 at 10:15 AM Gary Gregory wrote: > > I keep two repositories, one for master, one for releas

Re: Trying to Test and Build release-2.x Failing Locally

I replaced the tool chain of 14 with 8 and the build fails on the "API Java 9 support" project. If I added both toolchains, I get the same error as before. Here's how my toolchain.xml looks like now: jdk 14 sun C:\Program Files\Java\jdk-14.0.1

Re: Trying to Test and Build release-2.x Failing Locally

Use Java 8 means just that so yes you have to download it ;-) Gary On Thu, Apr 21, 2022, 12:57 Mohammed Barayyan wrote: > Does that mean I have to install JDK 8? or can I modify the toolchains or > the pom.xml to achieve that? > > On Thu, Apr 21, 2022 at 7:56 PM Gary Gregory > wrote: > > > Use

Re: Trying to Test and Build release-2.x Failing Locally

Thank you all very much. On Thu, Apr 21, 2022 at 8:09 PM Tim Perry wrote: > Yes, you need JDK 8. > https://www.azul.com/downloads/?version=java-8-lts&package=jdk or similar. > > On Thu, Apr 21, 2022 at 4:57 PM Mohammed Barayyan > > wrote: > > > Does that mean I have to install JDK 8? or can I m

Re: Trying to Test and Build release-2.x Failing Locally

Yes, you need JDK 8. https://www.azul.com/downloads/?version=java-8-lts&package=jdk or similar. On Thu, Apr 21, 2022 at 4:57 PM Mohammed Barayyan wrote: > Does that mean I have to install JDK 8? or can I modify the toolchains or > the pom.xml to achieve that? > > On Thu, Apr 21, 2022 at 7:56 PM

Re: Trying to Test and Build release-2.x Failing Locally

Does that mean I have to install JDK 8? or can I modify the toolchains or the pom.xml to achieve that? On Thu, Apr 21, 2022 at 7:56 PM Gary Gregory wrote: > Use Java 8, not 14. > > Gary > > On Thu, Apr 21, 2022, 12:35 Mohammed Barayyan > wrote: > > > Hello, > > > > Any advice on the issue pleas

Re: Trying to Test and Build release-2.x Failing Locally

Use Java 8, not 14. Gary On Thu, Apr 21, 2022, 12:35 Mohammed Barayyan wrote: > Hello, > > Any advice on the issue please. > > I'm trying to test and build branch 2.x from source but I get an error: > > error: cannot find symbol > [ERROR] symbol: class Reflection > [ERROR] location: packa

Trying to Test and Build release-2.x Failing Locally

Hello, Any advice on the issue please. I'm trying to test and build branch 2.x from source but I get an error: error: cannot find symbol [ERROR] symbol: class Reflection [ERROR] location: package sun.reflect More details about my question in: stackoverflow question https://stackoverflow.c

Re: does the master branch compile?

I keep two repositories, one for master, one for release-2.x, because of this kind of sillinesss. Gary On Thu, Apr 21, 2022, 08:04 Remko Popma wrote: > Thank you Piotr! > > Understood now. > Too bad that switching branches from 2.x to master leaves the invalid > source code under log4j-api/src/

Re: does the master branch compile?

Thank you Piotr! Understood now. Too bad that switching branches from 2.x to master leaves the invalid source code under log4j-api/src/test (and mvn clean also doesn’t remove it). I’ll just have to remember that I guess. :-) Thanks again for the quick reply. > On Apr 21, 2022, at 20:52, Pio

Re: does the master branch compile?

Hello Remko, On Thu, 21 Apr 2022 at 13:14, Remko Popma wrote: > Warnings look like this: > [WARNING] > > C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\LogManagerTest.java:[52,5] > [exports] class Test in module is not exported > In `master` there i

does the master branch compile?

Hi all, I am trying to merge the changes for LOG4J2-3472 into master, but I have trouble building the master branch... (and I don't think it is because of my changes) Am I missing something? My environment - C:\Users\remko\IdeaProjects\logging-log4j2>mvn --version Apache Maven