I couldn't understand why one of the two tests I added in this PR failed, and
root caused it to the linked change:
https://github.com/apache/logging-log4j2/pull/713
On Mon, Jan 17, 2022, at 16:28, Volkan Yazıcı wrote:
> Carter, how did you manage to promptly spot the glitch? I suppose you don't
>
Carter, how did you manage to promptly spot the glitch? I suppose you don't
have a custom CI pipeline of yours.
On Mon, Jan 17, 2022 at 7:51 PM Carter Kozak wrote:
> Please revert, this breaks stacklocatorutil on java 9+ with the following:
>
> Caused by: java.lang.NoSuchMethodError: 'java.util.
Adding a test in a java9+ module which passes an exception does not work after
the linked commit (e.g. https://github.com/apache/logging-log4j2/pull/713), it
seems we are missing test coverage. Testability is a strong reason to avoid
multi-release jars, but the alternatives leave a lot to be des
This could be fixed. It would require adding a log4j-api-java9-tests module
that sets toolchains
to Java 9 and runs whatever tests are in the module. Same for Log4j-core. You
don’t need to
run the full suite of tests. Just the stuff that is in the META-INF/versions
directory.
Ralph
> On Jan
Yes. The unit tests for core only exercise Java 8 as the build happens with
Java 8.
Ralph
> On Jan 17, 2022, at 12:48 PM, Gary Gregory wrote:
>
> How does this stack trace happen when my full local builds and github
> builds are green? Are we missing a test for this feature?
>
> Gary
>
>
How does this stack trace happen when my full local builds and github
builds are green? Are we missing a test for this feature?
Gary
On Mon, Jan 17, 2022, 13:51 Carter Kozak wrote:
> Please revert, this breaks stacklocatorutil on java 9+ with the following:
>
> Caused by: java.lang.NoSuchMetho
This may fix the regression: https://github.com/apache/logging-log4j2/pull/714
-ck
On Mon, Jan 17, 2022, at 13:50, Carter Kozak wrote:
> Please revert, this breaks stacklocatorutil on java 9+ with the following:
>
> Caused by: java.lang.NoSuchMethodError: 'java.util.Deque
> org.apache.logging.l
Thanks for the input. In that case I will certainly make sure that we
do keep the VFSLogFilePatternReceiver.
One thing that would be helpful if you have time Scott would be a
manual on how to use Chainsaw and the features that it has. I
understand it enough now, but for people first trying to us
Please revert, this breaks stacklocatorutil on java 9+ with the following:
Caused by: java.lang.NoSuchMethodError: 'java.util.Deque
org.apache.logging.log4j.util.StackLocator.getCurrentStackTrace()'
at
org.apache.logging.log4j.util.StackLocatorUtil.getCurrentStackTrace(StackLocatorUtil.java:116)
